Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/live 3369/restart when switching lang #1274

Conversation

mle-gall
Copy link
Contributor

@mle-gall mle-gall commented Sep 14, 2022

📝 Description

Updated restarting logic when switching from RTL to LTR and the other way.

❓ Context

  • Impacted projects: LLM
  • Linked resource(s): LIVE-3369

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

Screen.Recording.2022-09-14.at.10.46.42.mov

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Sep 14, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Sep 14, 2022 at 8:48AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Sep 14, 2022 at 8:48AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Sep 14, 2022 at 8:48AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Sep 14, 2022 at 8:48AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 14, 2022

⚠️ No Changeset found

Latest commit: c5fc182

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the mobile Has changes in LLM label Sep 14, 2022
@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Base: 47.00% // Head: 47.84% // Increases project coverage by +0.84% 🎉

Coverage data is based on head (c5fc182) compared to base (0484004).
Patch has no changes to coverable lines.

Additional details and impacted files
@@                          Coverage Diff                          @@
##           feat/LIVE-2987/RTL-arabic-support    #1274      +/-   ##
=====================================================================
+ Coverage                              47.00%   47.84%   +0.84%     
=====================================================================
  Files                                    627      650      +23     
  Lines                                  28200    29121     +921     
  Branches                                7397     7532     +135     
=====================================================================
+ Hits                                   13254    13933     +679     
- Misses                                 14898    15130     +232     
- Partials                                  48       58      +10     
Flag Coverage Δ
test 47.84% <ø> (+0.84%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...hw-transport-mocker/src/createTransportReplayer.ts 13.79% <0.00%> (ø)
libs/ledgerjs/packages/errors/src/helpers.ts 25.00% <0.00%> (ø)
libs/ledgerjs/packages/cryptoassets/data/asa.js 100.00% <0.00%> (ø)
libs/ledgerjs/packages/hw-app-solana/src/Solana.ts 100.00% <0.00%> (ø)
libs/ledgerjs/packages/hw-app-trx/src/utils.ts 61.40% <0.00%> (ø)
...hw-transport-mocker/src/createTransportRecorder.ts 13.04% <0.00%> (ø)
libs/ledgerjs/packages/cryptoassets/src/fiats.ts 100.00% <0.00%> (ø)
libs/ledgerjs/packages/cryptoassets/src/tokens.ts 75.00% <0.00%> (ø)
...dgerjs/packages/cryptoassets/data/cardanoNative.js 100.00% <0.00%> (ø)
libs/ledgerjs/packages/errors/src/index.ts 78.72% <0.00%> (ø)
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

@mlegall-ledger

Screenshots: ❌

It seems this PR contains screenshots that are different from the base branch.
If you are sure all those changes are correct, you can comment on this PR with /generate-screenshots to update those screenshots.

Make sure all the changes are correct before running the command, as it will commit and push the new result to the PR.

windows

Actual Diff Expected
market-btc-buy-page-actual market-btc-buy-page-diff market-btc-buy-page-expected
market-btc-buy-page-actual market-btc-buy-page-diff market-btc-buy-page-expected

@mle-gall mle-gall merged commit 89ed71c into feat/LIVE-2987/RTL-arabic-support Sep 14, 2022
@mle-gall mle-gall deleted the feat/LIVE-3369/restartWhenSwitchingLang branch September 14, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants