Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New modal to confirm language change + updated icons generation to su… #1289

Merged

Conversation

mle-gall
Copy link
Contributor

@mle-gall mle-gall commented Sep 15, 2022

…pport RTL

📝 Description

New modal to confirm language change (replacing Alert)
Updated icons generation to handle -rtl icons, by adding a symmetry switch if RTL to some icons

❓ Context

  • Impacted projects: LLM
  • Linked resource(s): LIVE-3370

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

N/A

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@mle-gall mle-gall requested a review from a team September 15, 2022 16:20
@vercel
Copy link

vercel bot commented Sep 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Sep 16, 2022 at 1:51PM (UTC)
native-ui-storybook ✅ Ready (Inspect) Visit Preview Sep 16, 2022 at 1:51PM (UTC)
react-ui-storybook ✅ Ready (Inspect) Visit Preview Sep 16, 2022 at 1:51PM (UTC)
1 Ignored Deployment
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Sep 16, 2022 at 1:51PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 15, 2022

⚠️ No Changeset found

Latest commit: 95f971d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Base: 47.84% // Head: 47.84% // No change to project coverage 👍

Coverage data is based on head (9d928dd) compared to base (c5fc182).
Patch has no changes to coverable lines.

❗ Current head 9d928dd differs from pull request most recent head 95f971d. Consider uploading reports for the commit 95f971d to get more accurate results

Additional details and impacted files
@@                        Coverage Diff                         @@
##           feat/LIVE-2987/RTL-arabic-support    #1289   +/-   ##
==================================================================
  Coverage                              47.84%   47.84%           
==================================================================
  Files                                    650      650           
  Lines                                  29121    29121           
  Branches                                7532     7532           
==================================================================
  Hits                                   13933    13933           
  Misses                                 15130    15130           
  Partials                                  58       58           
Flag Coverage Δ
test 47.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

@mlegall-ledger

Screenshots: ✅

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM translations Translation files have been touched ui Has changes in the design system library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants