-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New modal to confirm language change + updated icons generation to su… #1289
New modal to confirm language change + updated icons generation to su… #1289
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
Codecov ReportBase: 47.84% // Head: 47.84% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## feat/LIVE-2987/RTL-arabic-support #1289 +/- ##
==================================================================
Coverage 47.84% 47.84%
==================================================================
Files 650 650
Lines 29121 29121
Branches 7532 7532
==================================================================
Hits 13933 13933
Misses 15130 15130
Partials 58 58
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@mlegall-ledger Screenshots: ✅
There are no changes in the screenshots for this PR. If this is expected, you are good to go. |
…pport RTL
📝 Description
New modal to confirm language change (replacing Alert)
Updated icons generation to handle -rtl icons, by adding a symmetry switch if RTL to some icons
❓ Context
✅ Checklist
📸 Demo
N/A
🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.