-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/live 3251 ratings and notifs modals conflicts fixed #1322
Bugfix/live 3251 ratings and notifs modals conflicts fixed #1322
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: ee2c169 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
0eb6c4d
to
b0a4472
Compare
Codecov ReportBase: 43.64% // Head: 75.40% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1322 +/- ##
============================================
+ Coverage 43.64% 75.40% +31.76%
============================================
Files 610 59 -551
Lines 25543 3383 -22160
Branches 6971 701 -6270
============================================
- Hits 11148 2551 -8597
+ Misses 14346 831 -13515
+ Partials 49 1 -48
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Screenshots: ✅
There are no changes in the screenshots for this PR. If this is expected, you are good to go. |
…code specific to modals in a new file
…g causing the two modals to keep opening at the same time
216d735
to
377c248
Compare
…y account header removed
…y imports removed
📝 Description
Fixed a bug causing a freeze on ios when the ratings modal opened at the same time as the notifications one
Factorised some code regarding the navigation listener for the ratings and the push notifications
Fixed a navigation issue preventing the notifications modal to appear on the reborn account screens
❓ Context
ledger-live-mobile
✅ Checklist
📸 Demo
🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.