-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LIVE-3905 - LLD - fix toast issue when no click callback given #1381
LIVE-3905 - LLD - fix toast issue when no click callback given #1381
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: d95783a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
apps/ledger-live-desktop/src/renderer/components/ToastOverlay/Toast.jsx
Outdated
Show resolved
Hide resolved
dcb1c14
to
3b6f199
Compare
apps/ledger-live-desktop/src/renderer/components/ToastOverlay/Toast.jsx
Outdated
Show resolved
Hide resolved
apps/ledger-live-desktop/src/renderer/components/ToastOverlay/Toast.jsx
Outdated
Show resolved
Hide resolved
3b6f199
to
d95783a
Compare
Codecov ReportBase: 0.00% // Head: 48.11% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## release #1381 +/- ##
============================================
+ Coverage 0 48.11% +48.11%
============================================
Files 0 688 +688
Lines 0 30302 +30302
Branches 0 7894 +7894
============================================
+ Hits 0 14580 +14580
- Misses 0 14521 +14521
- Partials 0 1201 +1201
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
📝 Description
Failsafes an issue reported by sentry related to undefined toast callback causing crashes
❓ Context
ledger-live-desktop
✅ Checklist
📸 Demo
🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.