Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat / LIVE-3666 - New homepage tab navigator #1462

Merged
merged 5 commits into from
Oct 4, 2022
Merged

Feat / LIVE-3666 - New homepage tab navigator #1462

merged 5 commits into from
Oct 4, 2022

Conversation

nparigi-ledger
Copy link
Contributor

📝 Description

New homepage tab navigator with two screens :
Cryptos (the old portfolio/wallet page)
NFT (new page for the nft gallery)

  • new (empty) wallet nft gallery screen

❓ Context

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

Screen_Recording_20221004-164343_LL.DEV.mp4

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Oct 4, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Oct 4, 2022 at 3:18PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Oct 4, 2022 at 3:18PM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Oct 4, 2022 at 3:18PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Oct 4, 2022 at 3:18PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Oct 4, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 46fdb8e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added mobile Has changes in LLM translations Translation files have been touched labels Oct 4, 2022
mcayuelas-ledger
mcayuelas-ledger reviewed Oct 4, 2022
View reviewed changes
apps/ledger-live-mobile/src/components/RootNavigator/WalletTabNavigator.tsx
Comment on lines +35 to +38
paddingLeft={4}
paddingRight={4}
paddingBottom={4}
paddingTop={4}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p={4} no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, seems that this was on purpose because with the styled wrapper, just putting p={4} doesn't work ...

@mcayuelas-ledger mcayuelas-ledger merged commit 6fe4cde into feat/LIVE-3665-nft-gallery-v0 Oct 4, 2022
@mcayuelas-ledger mcayuelas-ledger deleted the feat/LIVE-3666-nft-tab-navigator branch October 4, 2022 15:29
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2022

@nparigi-ledger

Screenshots: ❌

It seems this PR contains screenshots that are different from the base branch.
If you are sure all those changes are correct, you can comment on this PR with /generate-screenshots to update those screenshots.

Make sure all the changes are correct before running the command, as it will commit and push the new result to the PR.

linux

Actual Diff Expected
v3-onboarding-complete-actual v3-onboarding-complete-diff v3-onboarding-complete-expected
v3-onboarding-complete-actual v3-onboarding-complete-diff v3-onboarding-complete-expected
v3-onboarding-complete-actual v3-onboarding-complete-diff v3-onboarding-complete-expected
v3-onboarding-complete-actual v3-onboarding-complete-diff v3-onboarding-complete-expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcayuelas-ledger mcayuelas-ledger mcayuelas-ledger approved these changes

Assignees

@nparigi-ledger nparigi-ledger

Labels
mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nparigi-ledger @mcayuelas-ledger