-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/FAT-133 Install set of apps from device actions + tool #1474
Conversation
c041db0
to
e843b5d
Compare
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 558c96d The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Screenshots: ✅
There are no changes in the screenshots for this PR. If this is expected, you are good to go. |
Codecov ReportBase: 44.86% // Head: 46.46% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1474 +/- ##
===========================================
+ Coverage 44.86% 46.46% +1.59%
===========================================
Files 627 659 +32
Lines 26903 28075 +1172
Branches 7259 7527 +268
===========================================
+ Hits 12071 13046 +975
- Misses 13687 13897 +210
+ Partials 1145 1132 -13
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
apps/ledger-live-mobile/src/components/DeviceAction/InstallSetOfApps/index.tsx
Outdated
Show resolved
Hide resolved
apps/ledger-live-mobile/src/components/DeviceAction/InstallSetOfApps/index.tsx
Outdated
Show resolved
Hide resolved
apps/ledger-live-mobile/src/components/DeviceAction/InstallSetOfApps/index.tsx
Outdated
Show resolved
Hide resolved
4d84067
to
558c96d
Compare
📝 Description
A step of the sync onboarding so this can only be tested through the Debug menu. This PR introduces the possibility of installing a set of apps from a remote firebase config to be used as part of a device setup flow. Only available on provider 12. Final wording and UI polishes to be done as part of FAT-82.
❓ Context
ledger-live-common, ledger-live-mobile
https://ledgerhq.atlassian.net/browse/FAT-133
✅ Checklist
📸 Demo
🚀 Expectations to reach
It's very important⚠️ for QA to focus on non regression for other flows that rely on device actions due to the changes introduced in this component. Those changes allow for a user of a device action to implement its own UI overriding the default one from
DeviceAction
but I might have broken something in the process.I would say cover send/receive/add accounts with error cases (unplug device, disconnect, reject).
Apart from the actual flow for the epic.
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.