Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/benchmarking Added tool to measure app installation time in the manager #1490

Merged
merged 4 commits into from
Oct 10, 2022

Conversation

juan-cortes
Copy link
Contributor

📝 Description

Enabling the ENABLE_BENCHMARKING either on the debug env menu or at launch will now show a UI element in the manager that measures app installation times. This should allow easier comparison and be more accurate than measuring based on your reflexes and manual work.

❓ Context

  • Impacted projects: ledger-live-mobile
  • Linked resource(s): https://ledgerhq.atlassian.net/browse/FAT-492

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

image

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Oct 6, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Oct 10, 2022 at 2:38PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Oct 10, 2022 at 2:38PM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Oct 10, 2022 at 2:38PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Oct 10, 2022 at 2:38PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Oct 6, 2022

🦋 Changeset detected

Latest commit: fdce153

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2022

@alexandremgo

Screenshots: ❌

It seems this PR contains screenshots that are different from the base branch.
If you are sure all those changes are correct, you can comment on this PR with /generate-screenshots to update those screenshots.

Make sure all the changes are correct before running the command, as it will commit and push the new result to the PR.

windows

Actual Diff Expected
discover-actual discover-diff discover-expected
discover-actual discover-diff discover-expected

@codecov
Copy link

codecov bot commented Oct 8, 2022

Codecov Report

Base: 43.57% // Head: 48.07% // Increases project coverage by +4.50% 🎉

Coverage data is based on head (f184c6f) compared to base (2802e2d).
Patch has no changes to coverable lines.

❗ Current head f184c6f differs from pull request most recent head fdce153. Consider uploading reports for the commit fdce153 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1490      +/-   ##
===========================================
+ Coverage    43.57%   48.07%   +4.50%     
===========================================
  Files          610      688      +78     
  Lines        25489    30263    +4774     
  Branches      6982     7914     +932     
===========================================
+ Hits         11106    14549    +3443     
- Misses       13255    14500    +1245     
- Partials      1128     1214      +86     
Flag Coverage Δ
test 48.07% <ø> (+4.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...edgerjs/packages/hw-app-btc/tests/newops/testtx.ts 100.00% <0.00%> (ø)
libs/ledgerjs/packages/hw-app-btc/src/Btc.ts 81.25% <0.00%> (ø)
libs/ledgerjs/packages/hw-app-cosmos/src/Cosmos.ts 20.73% <0.00%> (ø)
.../ledgerjs/packages/hw-app-btc/src/hashPublicKey.ts 100.00% <0.00%> (ø)
...bs/ledgerjs/packages/hw-app-btc/src/buffertools.ts 70.73% <0.00%> (ø)
...dgerjs/packages/hw-app-btc/src/newops/appClient.ts 23.07% <0.00%> (ø)
...js/packages/hw-app-btc/src/newops/psbtFinalizer.ts 78.57% <0.00%> (ø)
libs/ledgerjs/packages/cryptoassets/data/trc10.js 100.00% <0.00%> (ø)
libs/ledgerjs/packages/cryptoassets/data/erc20.js 100.00% <0.00%> (ø)
...s/packages/hw-app-eth/src/services/ledger/index.ts 81.96% <0.00%> (ø)
... and 71 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alexandremgo alexandremgo merged commit 26fbd95 into develop Oct 10, 2022
@alexandremgo alexandremgo deleted the feat/benchmarking branch October 10, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants