-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
π bugfix(Swap): LLM - Swap buttons not available on Currency and account screens #1533
π bugfix(Swap): LLM - Swap buttons not available on Currency and account screens #1533
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
π¦ Changeset detectedLatest commit: ee91bd6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportBase: 47.61% // Head: 47.61% // No change to project coverage π
Additional details and impacted files@@ Coverage Diff @@
## develop #1533 +/- ##
========================================
Coverage 47.61% 47.61%
========================================
Files 687 687
Lines 30258 30258
Branches 7912 7912
========================================
Hits 14407 14407
Misses 14632 14632
Partials 1219 1219
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. β View full report at Codecov. |
Screenshots: β
There are no changes in the screenshots for this PR. If this is expected, you are good to go. |
1c7e42f
to
ee91bd6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Button appears correctly now. I've noticed that non-default BTC accounts and non-BTC currecies aren't automatically selected as the 'From' currency when navigating to swap, but @mcayuelas-ledger tells me this is known and being dealt with in a separate Hub ticket
π Description
Swap buttons not available on Currency and account screens (Quick Actions)
β Context
live-mobile
β Checklist
πΈ Demo
π Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.