Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/LIVE-4049 - NFT viewer page design fix (v3) #1652

Merged
merged 5 commits into from
Oct 24, 2022
Merged

Feat/LIVE-4049 - NFT viewer page design fix (v3) #1652

merged 5 commits into from
Oct 24, 2022

Conversation

nparigi-ledger
Copy link
Contributor

📝 Description

NFT viewer page design fix (v3)

❓ Context

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

Screen_Recording_20221021-165946_LL.DEV.mp4

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Oct 21, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Oct 24, 2022 at 4:00PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Oct 24, 2022 at 4:00PM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Oct 24, 2022 at 4:00PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Oct 24, 2022 at 4:00PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Oct 21, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: a899e89

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the mobile Has changes in LLM label Oct 21, 2022
@nparigi-ledger
Merge branch 'feat/LIVE-3665-nft-gallery-v0' of github.com:LedgerHQ/l…
b1fe477 
…edger-live into feat/LIVE-4049-nft-viewer-page-quick-design-fix

# Conflicts:
#	apps/ledger-live-mobile/src/components/Nft/NftLinksPanel.tsx
@nparigi-ledger nparigi-ledger merged commit c40be85 into feat/LIVE-3665-nft-gallery-v0 Oct 24, 2022
@nparigi-ledger nparigi-ledger deleted the feat/LIVE-4049-nft-viewer-page-quick-design-fix branch October 24, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcayuelas-ledger mcayuelas-ledger mcayuelas-ledger approved these changes

Assignees

@nparigi-ledger nparigi-ledger

Labels
mobile Has changes in LLM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nparigi-ledger @mcayuelas-ledger