-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add install set of apps step in mobile sync onboarding #1667
Add install set of apps step in mobile sync onboarding #1667
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: a375923 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
apps/ledger-live-mobile/src/components/DeviceAction/InstallSetOfApps/index.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me otherwise, clean work :)
Screenshots: ✅
There are no changes in the screenshots for this PR. If this is expected, you are good to go. |
be346b4
to
fe64632
Compare
Codecov ReportBase: 47.94% // Head: 47.94% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## develop #1667 +/- ##
========================================
Coverage 47.94% 47.94%
========================================
Files 691 691
Lines 30458 30458
Branches 7990 7990
========================================
Hits 14604 14604
+ Misses 14657 14640 -17
- Partials 1197 1214 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
📝 Description
Add an extra step in the sync onboarding flow to propose installing a default set of apps to the user after genuine check. The app list in flagged, and the fallback in case of network problem is BTC, ETH and Polygon.
❓ Context
ledger-live-mobile
✅ Checklist
Test coverage: no UI testing on mobile yet📸 Demo
N/A, see slack channels
🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.