Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

βœ… Add firsts Tests for NFT Gallery #1697

Merged

Conversation

mcayuelas-ledger
Copy link
Contributor

πŸ“ Description

βœ… Add firsts Tests for NFT Gallery

❓ Context

  • Impacted projects: live-mobile live-common
  • Linked resource(s): ``

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

πŸš€ Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Oct 27, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
live-common-tools βœ… Ready (Inspect) Visit Preview Oct 27, 2022 at 9:08AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Oct 27, 2022 at 9:08AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Oct 27, 2022 at 9:08AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Oct 27, 2022 at 9:08AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2022

⚠️ No Changeset found

Latest commit: 1c9b530

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the common Has changes in live-common label Oct 27, 2022
@github-actions
Copy link
Contributor

@mcayuelas-ledger

Screenshots: βœ…

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@mcayuelas-ledger mcayuelas-ledger merged commit a6e5d55 into feat/LIVE-3665-nft-gallery-v0 Oct 27, 2022
@mcayuelas-ledger mcayuelas-ledger deleted the feat/nft-gallery-test branch October 27, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants