Support: FAT-597 quick fix for 0x5515 error #1741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 30ca4d8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
mobile
Codecov ReportBase: 87.12% // Head: 46.97% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1741 +/- ##
============================================
- Coverage 87.12% 46.97% -40.15%
============================================
Files 12 690 +678
Lines 233 30462 +30229
Branches 45 8044 +7999
============================================
+ Hits 203 14311 +14108
- Misses 30 14920 +14890
- Partials 0 1231 +1231
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Screenshots: ✅
There are no changes in the screenshots for this PR. If this is expected, you are good to go. |
alexandremgo
force-pushed
the
support/FAT-597-quickfix-5515-error
branch
from
c868381 to
90ff9cb
Compare
juan-cortes
approved these changes
Nov 3, 2022
apps/ledger-live-desktop/src/renderer/components/DeviceAction/rendering.tsx
Show resolved
Hide resolved
github-actions
bot
added
common
alexandremgo
force-pushed
the
support/FAT-597-quickfix-5515-error
branch
from
50e8428 to
19814f0
Compare
alexandremgo
force-pushed
the
support/FAT-597-quickfix-5515-error
branch
from
19814f0 to
c6e4512
Compare
alexandremgo
force-pushed
the
support/FAT-597-quickfix-5515-error
branch
from
1b7922f to
c461fcf
Compare
alexandremgo
force-pushed
the
support/FAT-597-quickfix-5515-error
branch
from
c461fcf to
d73c510
Compare
alexandremgo
force-pushed
the
support/FAT-597-quickfix-5515-error
branch
from
d73c510 to
3e2d4a5
Compare
alexandremgo
force-pushed
the
support/FAT-597-quickfix-5515-error
branch
from
3e2d4a5 to
752d0a4
Compare
alexandremgo
force-pushed
the
support/FAT-597-quickfix-5515-error
branch
from
752d0a4 to
1aec02e
Compare
alexandremgo
force-pushed
the
support/FAT-597-quickfix-5515-error
branch
from
1aec02e to
30ca4d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
A quick fix for all the
0x5515locked device cases.Needed because the kind of fix made in this PR will take longer to implement everywhere, and do not work currently on LLD as is.
Edit: i actually had to modify a bit more stuff for 2 reasons:
1. Not all
0x5515error are thrown during a device actionit turns out there are a lot of scenarios where we could have a
0x5515error outside the usage of a device action. So the remapping insiderenderErrorin both LLD and LLM would not catch those.To handle those scenarios: i remapped
TransportStatusError+status-code = 0x5515into a new errorLockedDeviceError.I kept the specific rendering inside the device action
renderLockedDeviceErrorso we have a nicer UI for the user.But outside a device action the component
TranslatedErrorfor both LLM and LLD will display an error, but with an informative message that is associated to the errorLockedDeviceErrorBecause of this mapping to
LockedDeviceError, i had to modify a couple of other files that had conditions onStatusCodes.LOCKED_DEVICE:libs/ledger-live-common/src/hw/connectApp.tslibs/ledger-live-common/src/hw/connectManager.tslibs/ledger-live-common/src/hw/getDeviceRunningMode.ts2. isLocked status in LLD
Because since this PR we now handle
LockedDeviceErrorfor connectApp and connectManager, which update the status ofisLocked, we need to also handle the cases wereisLockedis set during a device action in LLD❓ Context
✅ Checklist
📸 Demo
📱 LLM
LLM inside a device action
LLM outside a device action
💻 LLD
LLD inside a device action
LLD outside a device action
🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.