New edit flow

[thomasrogerlux]

📝 Description

Rework the custom edit flow. For more information see the proper Slack channels.

❓ Context

• Impacted projects: ledger-live-mobile
• Linked resource(s): FAT-600, FAT-605

✅ Checklist

• Test coverage: no UI testing on mobile yet
• Atomic delivery
• No breaking changes

📸 Demo

N/A, see slack channels

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
live-common-tools	✅ Ready (Inspect)	Visit Preview	Nov 22, 2022 at 10:04AM (UTC)

3 Ignored Deployments

Name	Status	Preview	Updated
ledger-live-github-bot	⬜️ Ignored (Inspect)		Nov 22, 2022 at 10:04AM (UTC)
native-ui-storybook	⬜️ Ignored (Inspect)		Nov 22, 2022 at 10:04AM (UTC)
react-ui-storybook	⬜️ Ignored (Inspect)		Nov 22, 2022 at 10:04AM (UTC)

[changeset-bot]

🦋 Changeset detected

Latest commit: fc70950

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
live-mobile	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

@ofreyssinet-ledger

Screenshots: ✅

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

[codecov]

Codecov Report

Base: 47.83% // Head: 63.15% // Increases project coverage by +15.31% 🎉

Coverage data is based on head (b852dfe) compared to base (d10c727).
Patch has no changes to coverable lines.

❗ Current head b852dfe differs from pull request most recent head fc70950. Consider uploading reports for the commit fc70950 to get more accurate results

Additional details and impacted files

@@             Coverage Diff              @@
##           develop    #1774       +/-   ##
============================================
+ Coverage    47.83%   63.15%   +15.31%     
============================================
  Files          704        1      -703     
  Lines        30822       57    -30765     
  Branches      8129        7     -8122     
============================================
- Hits         14745       36    -14709     
+ Misses       14846       18    -14828     
+ Partials      1231        3     -1228     

Flag	Coverage Δ
test	63.15% <ø> (+15.31%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
libs/ledgerjs/packages/hw-app-trx/src/Trx.ts
libs/ledger-live-common/src/network.ts
...-live-common/src/hw/getGenuineCheckFromDeviceId.ts
...mmon/src/families/tezos/deviceTransactionConfig.ts
...live-common/src/families/polkadot/hw-getAddress.ts
...ve-common/src/families/crypto_org/serialization.ts
...ledger-live-common/src/families/osmosis/account.ts
...er-live-common/src/families/polkadot/validators.ts
...er-live-common/src/families/solana/js-broadcast.ts
...ger-live-common/src/migrations/accounts-dataset.ts
... and 693 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[ofreyssinet-ledger]

Great job!

Just one thing: it would be great to remove any processing logic from PreviewPostEdit as it's already happening in the previous screen Step2Preview.
It would be much simpler in my opinion. Basically you have to revert some of the changes you did in Step2Preview and just pass the ProcessorRawResult to PreviewPostEdit.

[ofreyssinet-ledger]

nice! good job