Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove navigation from buy / sell live app topbar #1785

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Conversation

chabroA
Copy link
Contributor

@chabroA chabroA commented Nov 10, 2022

📝 Description

Remove navigation for buy / sell screen

cf. https://ledgerhq.atlassian.net/browse/LIVE-4522

❓ Context

  • Impacted projects: ``
  • Linked resource(s): ``

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Nov 10, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Nov 10, 2022 at 4:21PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Nov 10, 2022 at 4:21PM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Nov 10, 2022 at 4:21PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Nov 10, 2022 at 4:21PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Nov 10, 2022

⚠️ No Changeset found

Latest commit: c0b14cf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Base: 0.00% // Head: 42.88% // Increases project coverage by +42.88% 🎉

Coverage data is based on head (c0b14cf) compared to base (25a4e5c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1785       +/-   ##
============================================
+ Coverage         0   42.88%   +42.88%     
============================================
  Files            0      613      +613     
  Lines            0    25652    +25652     
  Branches         0     7036     +7036     
============================================
+ Hits             0    11002    +11002     
- Misses           0    14599    +14599     
- Partials         0       51       +51     
Flag Coverage Δ
test 42.88% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ibs/ledger-live-common/src/families/evm/api/rpc.ts 100.00% <0.00%> (ø)
...live-common/src/families/bitcoin/hw-signMessage.ts 33.33% <0.00%> (ø)
...mmon/src/families/celo/js-getFeesForTransaction.ts 6.94% <0.00%> (ø)
libs/ledger-live-common/src/account/index.ts 100.00% <0.00%> (ø)
...er-live-common/src/api/explorerConfig/overrides.ts 97.01% <0.00%> (ø)
...ive-common/src/families/crypto_org/js-broadcast.ts 41.66% <0.00%> (ø)
...edger-live-common/src/families/ripple/bridge/js.ts 22.60% <0.00%> (ø)
...live-common/src/families/ethereum/signOperation.ts 23.80% <0.00%> (ø)
...-live-common/src/families/evm/createTransaction.ts 100.00% <0.00%> (ø)
...edger-live-common/src/families/stellar/exchange.ts 50.00% <0.00%> (ø)
... and 603 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

@chabroA

Screenshots: ✅

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@chabroA chabroA merged commit 90a621e into develop Nov 16, 2022
@chabroA chabroA deleted the feat/LIVE-4522 branch November 16, 2022 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants