-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix/LIVE-4591 Fix navigation lock bug on top left (back) navigation #1827
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 22016bb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportBase: 0.00% // Head: 76.95% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1827 +/- ##
============================================
+ Coverage 0 76.95% +76.95%
============================================
Files 0 24 +24
Lines 0 1918 +1918
Branches 0 368 +368
============================================
+ Hits 0 1476 +1476
- Misses 0 422 +422
- Partials 0 20 +20
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the navigation doc it's good :)
QA ok, this can be merged |
bugfix/LIVE-4591 Fix navigation lock bug on top left (back) navigation
📝 Description
This fixes a regression that made the Quit Manager confirmation modal show every time even if we didn't have any pending actions as long as we performed one or more actions in that session. So, for example, if you enter manager and install BTC, wait for it to complete and then attempt to quit, it will still prompt you to confirm the action because of pending operations.
❓ Context
ledger-live-mobile
https://ledgerhq.atlassian.net/browse/LIVE-4591
✅ Checklist
🚀 Expectations to reach