Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/LIVE-4591 Fix navigation lock bug on top left (back) navigation #1827

Merged
merged 4 commits into from
Nov 18, 2022

Conversation

juan-cortes
Copy link
Contributor

📝 Description

This fixes a regression that made the Quit Manager confirmation modal show every time even if we didn't have any pending actions as long as we performed one or more actions in that session. So, for example, if you enter manager and install BTC, wait for it to complete and then attempt to quit, it will still prompt you to confirm the action because of pending operations.

❓ Context

  • Impacted projects: ledger-live-mobile
  • Linked resource(s): https://ledgerhq.atlassian.net/browse/LIVE-4591

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

🚀 Expectations to reach

  • User should be able to quit the manager without having to confirm if there are no pending actions running at the time of clicking the back arrow.

@vercel
Copy link

vercel bot commented Nov 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Nov 16, 2022 at 0:47AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Nov 16, 2022 at 0:47AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Nov 16, 2022 at 0:47AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Nov 16, 2022 at 0:47AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Nov 16, 2022

🦋 Changeset detected

Latest commit: 22016bb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the mobile Has changes in LLM label Nov 16, 2022
@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Base: 0.00% // Head: 76.95% // Increases project coverage by +76.95% 🎉

Coverage data is based on head (cae7796) compared to base (6a3604c).
Patch has no changes to coverable lines.

❗ Current head cae7796 differs from pull request most recent head 22016bb. Consider uploading reports for the commit 22016bb to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1827       +/-   ##
============================================
+ Coverage         0   76.95%   +76.95%     
============================================
  Files            0       24       +24     
  Lines            0     1918     +1918     
  Branches         0      368      +368     
============================================
+ Hits             0     1476     +1476     
- Misses           0      422      +422     
- Partials         0       20       +20     
Flag Coverage Δ
test 76.95% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libs/ledgerjs/packages/hw-app-cosmos/src/Cosmos.ts 20.73% <0.00%> (ø)
libs/ledgerjs/packages/hw-app-eth/src/errors.ts 100.00% <0.00%> (ø)
libs/ledgerjs/packages/hw-app-eth/src/Eth.ts 79.04% <0.00%> (ø)
libs/ledgerjs/packages/hw-app-eth/src/utils.ts 94.80% <0.00%> (ø)
libs/ledgerjs/packages/hw-app-str/src/Str.ts 68.75% <0.00%> (ø)
...ckages/hw-app-eth/src/services/ledger/contracts.ts 95.65% <0.00%> (ø)
...js/packages/hw-app-eth/src/services/ledger/nfts.ts 97.14% <0.00%> (ø)
...s/packages/hw-app-eth/src/services/ledger/erc20.ts 93.44% <0.00%> (ø)
...dgerjs/packages/hw-app-helium/src/serialization.ts 86.58% <0.00%> (ø)
.../ledgerjs/packages/hw-app-algorand/src/Algorand.ts 29.03% <0.00%> (ø)
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@alexandremgo alexandremgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the navigation doc it's good :)

@alalmi-ledger
Copy link
Contributor

QA ok, this can be merged

@cgrellard-ledger cgrellard-ledger merged commit b926507 into develop Nov 18, 2022
@cgrellard-ledger cgrellard-ledger deleted the bugfix/LIVE-4591 branch November 18, 2022 09:21
cgrellard-ledger added a commit that referenced this pull request Nov 18, 2022
bugfix/LIVE-4591 Fix navigation lock bug on top left (back) navigation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants