Fastlane/Firebase config: use stagingRelease buildType for :apk and :apk_local builds #1833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 447353c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ofreyssinet-ledger
changed the title
ofreyssinet-ledger
changed the title
| @@ -1,7 +1,6 @@ | |||
| APP_NAME="Ledger Live" | |||
| SENTRY_DSN=https://ea730d6c531f40679e7306c888f7fbc5@o118392.ingest.sentry.io/6723478 | |||
| ANALYTICS_TOKEN=jfUZbw28ig8JpEi9DZpTUc21dKUKu1e3 | |||
| GOOGLE_SERVICE_INFO_NAME="GoogleService-Info-Production" | |||
There was a problem hiding this comment.
This is unused and it's confusing everyone. Unfortunately we cannot easily configure Google services (thus Firebase) dynamically with a simple environment variable.
valpinkman
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Right now, non-release builds triggered from the CI on Android have a
"release"buildType. Unfortunately, Firebase is configured statically withgoogle-services.jsonfiles that are different depending on thebuildType.Since these non-release builds should be considered as "staging" builds, it seems normal that they use the staging configuration for Firebase, and thus target the staging Firebase project.
So this PR changes the logic of builds so that they use the
"stagingRelease"buildType. It will have two impacts:"com.ledger.live.staging", so they will be installed separately from the prod application.❓ Context
ledger-live-mobile✅ Checklist
📸 Demo
🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.