Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/LIVE-4622 Fix DebugHttpTransport screen #1859

Merged
merged 3 commits into from
Nov 18, 2022
Merged

Conversation

juan-cortes
Copy link
Contributor

@juan-cortes juan-cortes commented Nov 17, 2022

📝 Description

With the new and improved device selector screen we forgot to account for the debug http logic and it was causing a crash after adding a device through that screen.

❓ Context

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

@vercel
Copy link

vercel bot commented Nov 17, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Nov 17, 2022 at 8:12PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Nov 17, 2022 at 8:12PM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Nov 17, 2022 at 8:12PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Nov 17, 2022 at 8:12PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Nov 17, 2022

🦋 Changeset detected

Latest commit: a6693e4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Base: 0.00% // Head: 47.29% // Increases project coverage by +47.29% 🎉

Coverage data is based on head (a6693e4) compared to base (c5bd929).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1859       +/-   ##
============================================
+ Coverage         0   47.29%   +47.29%     
============================================
  Files            0      702      +702     
  Lines            0    30692    +30692     
  Branches         0     8090     +8090     
============================================
+ Hits             0    14517    +14517     
- Misses           0    14942    +14942     
- Partials         0     1233     +1233     
Flag Coverage Δ
test 47.29% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libs/ledgerjs/packages/hw-app-btc/src/BtcOld.ts 96.15% <0.00%> (ø)
...ger-live-common/src/families/ripple/bridge/mock.ts 70.31% <0.00%> (ø)
libs/ledger-live-common/src/nft/support.ts 100.00% <0.00%> (ø)
...ommon/src/families/celo/js-getTransactionStatus.ts 14.92% <0.00%> (ø)
...e-common/src/bridge/react/SyncSkipUnderPriority.ts 20.00% <0.00%> (ø)
...ve-common/src/families/stellar/js-signOperation.ts 22.91% <0.00%> (ø)
...ommon/src/families/celo/deviceTransactionConfig.ts 16.66% <0.00%> (ø)
...live-common/src/ble/hooks/useBleDevicesScanning.ts 90.00% <0.00%> (ø)
libs/ledger-live-common/src/account/index.ts 100.00% <0.00%> (ø)
.../ledgerjs/packages/hw-app-algorand/src/Algorand.ts 29.03% <0.00%> (ø)
... and 692 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@juan-cortes juan-cortes merged commit 4764032 into develop Nov 18, 2022
@juan-cortes juan-cortes deleted the bugfix/LIVE-4622 branch November 18, 2022 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants