-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix/LIVE-4623 Fix crash on Android 12+ during FW Update #1867
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 9cb8da4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ae5e0e1
to
d208708
Compare
Codecov ReportBase: 47.74% // Head: 43.82% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## release #1867 +/- ##
===========================================
- Coverage 47.74% 43.82% -3.92%
===========================================
Files 702 636 -66
Lines 30701 26320 -4381
Branches 8092 7216 -876
===========================================
- Hits 14658 11536 -3122
+ Misses 14839 14724 -115
+ Partials 1204 60 -1144
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
QA OK, this can be merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
cd5d028
to
9cb8da4
Compare
📝 Description
Starting on Android 12+ a hard requirement was introduced to set a flag on
PendingIntent
that caused a crash when attempting a firmware update. Following the error logs, this PR introduces said flag for affected versions.❓ Context
ledger-live-mobile
https://ledgerhq.atlassian.net/browse/LIVE-4623
✅ Checklist
🚀 Expectations to reach