Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: test CI on Bugfix/FAT-588 #1964

Closed
wants to merge 2 commits into from
Closed

Conversation

alexandremgo
Copy link
Contributor

πŸ“ Description

Testing the CI for the PR 1871

❓ Context

  • Impacted projects: none - should not be merged as is
  • Linked resource(s): ``

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

πŸš€ Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@changeset-bot
Copy link

changeset-bot bot commented Nov 25, 2022

πŸ¦‹ Changeset detected

Latest commit: 7fc883a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@ledgerhq/live-common Patch
@ledgerhq/react-native-hw-transport-ble Patch
live-mobile Patch
@ledgerhq/live-cli Patch
ledger-live-desktop Patch
live-common-tools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Nov 25, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
live-common-tools βœ… Ready (Inspect) Visit Preview Nov 25, 2022 at 2:46PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Nov 25, 2022 at 2:46PM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Nov 25, 2022 at 2:46PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Nov 25, 2022 at 2:46PM (UTC)

@github-actions github-actions bot added common Has changes in live-common desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs translations Translation files have been touched labels Nov 25, 2022
@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Base: 42.85% // Head: 44.92% // Increases project coverage by +2.06% πŸŽ‰

Coverage data is based on head (33a156b) compared to base (d5bc651).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head 33a156b differs from pull request most recent head 7fc883a. Consider uploading reports for the commit 7fc883a to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1964      +/-   ##
===========================================
+ Coverage    42.85%   44.92%   +2.06%     
===========================================
  Files          624      639      +15     
  Lines        25892    27169    +1277     
  Branches      7158     7413     +255     
===========================================
+ Hits         11097    12205    +1108     
- Misses       13638    13796     +158     
- Partials      1157     1168      +11     
Flag Coverage Ξ”
test 44.92% <0.00%> (+2.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
libs/ledger-live-common/src/apps/runner.ts 50.00% <0.00%> (-2.84%) ⬇️
libs/ledgerjs/packages/hw-app-eth/src/Eth.ts 79.04% <0.00%> (ΓΈ)
libs/ledgerjs/packages/errors/src/index.ts 75.32% <0.00%> (ΓΈ)
...s/packages/hw-app-eth/tests/fixtures/dynamicCAL.ts 100.00% <0.00%> (ΓΈ)
libs/ledgerjs/packages/hw-app-eth/src/utils.ts 94.80% <0.00%> (ΓΈ)
...s/packages/hw-app-eth/src/services/ledger/index.ts 98.57% <0.00%> (ΓΈ)
...ledgerjs/packages/hw-app-eth/tests/fixtures/CAL.ts 100.00% <0.00%> (ΓΈ)
...dgerjs/packages/hw-app-eth/tests/fixtures/utils.ts 100.00% <0.00%> (ΓΈ)
libs/ledgerjs/packages/hw-app-eth/src/errors.ts 100.00% <0.00%> (ΓΈ)
...ckages/hw-app-eth/src/services/ledger/contracts.ts 95.65% <0.00%> (ΓΈ)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report at Codecov.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2022

@alexandremgo

Screenshots: βœ…

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@valpinkman valpinkman deleted the bugfix/test-ci-FAT-588 branch June 23, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants