Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cardano tokens on LLD + LLM #462

Merged
66 commits merged into from
Jul 20, 2022
Merged

Cardano tokens on LLD + LLM #462

66 commits merged into from
Jul 20, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jun 24, 2022

πŸ“ Description

Add support of tokens on LLD and LLM in addition to current Cardano integration which just covers send/receive.

❓ Context

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

πŸš€ Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@ghost ghost self-requested a review June 24, 2022 11:22
@live-github-bot
Copy link
Contributor

❌ @haammar-ledger

Unfortunately this PR does not comply with the Contributing Conventions and will be closed automatically.

Feel free to reopen this PR once you have browsed through the guidelines.


Found Issues:

  • the description is missing or you removed or overrode one or more sections of the pull request template

@vercel
Copy link

vercel bot commented Jun 24, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
live-common-tools βœ… Ready (Inspect) Visit Preview Jul 20, 2022 at 2:43PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Jul 20, 2022 at 2:43PM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Jul 20, 2022 at 2:43PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Jul 20, 2022 at 2:43PM (UTC)

@live-github-bot live-github-bot bot closed this Jun 24, 2022
@changeset-bot
Copy link

changeset-bot bot commented Jun 24, 2022

πŸ¦‹ Changeset detected

Latest commit: a264a07

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
ledger-live-desktop Minor
@ledgerhq/live-common Minor
@ledgerhq/cryptoassets Minor
@ledgerhq/live-cli Patch
live-mobile Patch
live-common-tools Patch
@ledgerhq/hw-app-eth Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot assigned ghost Jun 24, 2022
@github-actions github-actions bot added common Has changes in live-common desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs labels Jun 24, 2022
@ghost ghost reopened this Jun 24, 2022
@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Merging #462 (a264a07) into release (6a5c562) will decrease coverage by 0.05%.
The diff coverage is 23.07%.

@@             Coverage Diff             @@
##           release     #462      +/-   ##
===========================================
- Coverage    47.49%   47.43%   -0.06%     
===========================================
  Files          621      623       +2     
  Lines        27668    27743      +75     
  Branches      7131     7156      +25     
===========================================
+ Hits         13140    13160      +20     
- Misses       13413    13460      +47     
- Partials      1115     1123       +8     
Flag Coverage Ξ”
test 47.43% <23.07%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
libs/ledger-live-common/src/apps/support.ts 31.81% <ΓΈ> (ΓΈ)
...ve-common/src/families/cardano/buildSubAccounts.ts 19.44% <0.00%> (-0.85%) ⬇️
...on/src/families/cardano/js-estimateMaxSpendable.ts 31.81% <0.00%> (-1.52%) ⬇️
...ve-common/src/families/cardano/js-signOperation.ts 15.95% <0.00%> (-0.90%) ⬇️
...live-common/src/families/cardano/js-transaction.ts 30.00% <0.00%> (ΓΈ)
...on/src/families/cardano/js-getTransactionStatus.ts 17.64% <14.28%> (-0.27%) ⬇️
...s/ledger-live-common/src/families/cardano/logic.ts 20.12% <16.66%> (-0.14%) ⬇️
...-common/src/families/cardano/js-synchronisation.ts 19.04% <19.04%> (+0.15%) ⬆️
...on/src/families/cardano/deviceTransactionConfig.ts 19.44% <19.44%> (ΓΈ)
.../ledger-live-common/src/families/cardano/errors.ts 100.00% <100.00%> (ΓΈ)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 6a5c562...a264a07. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jun 24, 2022

@haammar-ledger

Screenshots: βœ…

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@github-actions github-actions bot added cli tools Has changes in tools ui Has changes in the design system library labels Jul 19, 2022
@hzheng-ledger hzheng-ledger changed the base branch from develop to release July 19, 2022 13:21
@github-actions github-actions bot removed ui Has changes in the design system library tools Has changes in tools cli labels Jul 19, 2022
@ghost ghost merged commit 816f2b7 into release Jul 20, 2022
@ghost ghost deleted the feat/cardano branch July 20, 2022 16:36
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common desktop Has changes in LLD feature ready ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants