LLM notifications prompts #507

jules-grenier-ledger · 2022-06-28T15:45:59Z

📝 Description

v0 of the Notifications in LLM

New Modal to ask user to enable Notifications that is triggered only when specific criterias are met (same as for the ratings modal).
New section in the settings to handle notifications options.
Two options added to the feature flags in LLC : languages_whitelisted and languages_blacklisted to enable or disable respectively any feature flagged feature for just some languages in the remote config.

❓ Context

Impacted projects: ledger-live-mobile ledger-live-common
Linked resource(s):
- Jira Epic : LL-2536
- Figma : https://www.figma.com/file/uQYdD0E0ELDKi3skrduZpw/LLM-%2F-Notifications?node-id=2107%3A35591

✅ Checklist

Test coverage
Atomic delivery
No breaking changes

📸 Demo

Fix for this ticket LIVE-3076

Record_2022-06-23-16-02-27.mp4

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

vercel · 2022-06-28T15:46:02Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
live-common-tools	✅ Ready (Inspect)	Visit Preview	Jul 29, 2022 at 7:24AM (UTC)
native-ui-storybook	✅ Ready (Inspect)	Visit Preview	Jul 29, 2022 at 7:24AM (UTC)

2 Ignored Deployments

Name	Status	Preview	Updated
ledger-live-github-bot	⬜️ Ignored (Inspect)		Jul 29, 2022 at 7:24AM (UTC)
react-ui-storybook	⬜️ Ignored (Inspect)		Jul 29, 2022 at 7:24AM (UTC)

changeset-bot · 2022-06-28T15:46:03Z

🦋 Changeset detected

Latest commit: 671a3fd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages

Name	Type
live-mobile	Minor
@ledgerhq/live-common	Minor
@ledgerhq/live-cli	Patch
ledger-live-desktop	Patch
live-common-tools	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2022-07-20T13:56:21Z

@LFBarreto

Screenshots: ✅

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

codecov · 2022-07-20T13:59:12Z

Codecov Report

Merging #507 (671a3fd) into release (1a64f6a) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           release     #507      +/-   ##
===========================================
- Coverage    47.50%   47.49%   -0.01%     
===========================================
  Files          623      623              
  Lines        27751    27751              
  Branches      7160     7160              
===========================================
- Hits         13182    13181       -1     
- Misses       13447    13448       +1     
  Partials      1122     1122

Flag	Coverage Δ
test	`47.49% <ø> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
libs/ledger-live-common/src/range.ts	`94.87% <0.00%> (-2.57%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a64f6a...671a3fd. Read the comment docs.

LFBarreto

some little tweaks 😉

LFBarreto · 2022-07-20T15:35:19Z

apps/ledger-live-mobile/src/logic/notifications.tsx

+        if (!notificationsToken) {
+            const token = await messaging().getToken();
+            setNotificationsToken(token);
+            messaging().onMessage(async remoteMessage => {


i see a lot of messaging().xxx does messaging() return an instance of FCM and wouldn't it be better to set a const in the component linking to it to not repeat this? 🤔 (maybe it will stop working idk)

apps/ledger-live-mobile/src/screens/Market/MarketDetail/index.tsx

apps/ledger-live-mobile/src/screens/Onboarding/steps/pairNew.tsx

…ons feature flag is disabled

gre · 2022-07-28T09:39:21Z

conflict on the pnpm lock @jules-grenier-ledger

…IVE-2536-llm-notifications-prompts

github-actions bot assigned jules-grenier-ledger Jun 28, 2022

github-actions bot added mobile Has changes in LLM translations Translation files have been touched labels Jun 28, 2022

jules-grenier-ledger marked this pull request as draft June 28, 2022 15:46

jules-grenier-ledger force-pushed the feat/LIVE-2536-llm-notifications-prompts branch from d684f71 to 287e6c3 Compare June 29, 2022 13:05

vercel bot had a problem deploying to Preview – live-common-tools June 29, 2022 13:06 Failure

jules-grenier-ledger force-pushed the feat/LIVE-2536-llm-notifications-prompts branch from 287e6c3 to 1a01d6b Compare June 29, 2022 13:44

vercel bot had a problem deploying to Preview – live-common-tools June 29, 2022 13:45 Failure

vercel bot had a problem deploying to Preview – live-common-tools July 13, 2022 12:39 Failure

github-actions bot added the common Has changes in live-common label Jul 19, 2022

vercel bot had a problem deploying to Preview – live-common-tools July 19, 2022 17:29 Failure

vercel bot had a problem deploying to Preview – live-common-tools July 20, 2022 11:02 Failure

cgrellard-ledger force-pushed the feat/LIVE-2536-llm-notifications-prompts branch from 1767873 to 457fcd0 Compare July 20, 2022 11:12

vercel bot deployed to Preview – live-common-tools July 20, 2022 11:16 View deployment

vercel bot deployed to Preview – live-common-tools July 20, 2022 11:20 View deployment

cgrellard-ledger force-pushed the feat/LIVE-2536-llm-notifications-prompts branch from a46d789 to 359ad70 Compare July 20, 2022 13:33

vercel bot deployed to Preview – live-common-tools July 20, 2022 13:36 View deployment

cgrellard-ledger marked this pull request as ready for review July 20, 2022 13:42

LFBarreto suggested changes Jul 20, 2022

View reviewed changes

LFBarreto approved these changes Jul 20, 2022

View reviewed changes

vercel bot deployed to Preview – live-common-tools July 21, 2022 09:33 View deployment

vercel bot deployed to Preview – live-common-tools July 22, 2022 10:43 View deployment

vercel bot deployed to Preview – live-common-tools July 25, 2022 20:23 View deployment

vercel bot deployed to Preview – live-common-tools July 26, 2022 10:30 View deployment

vercel bot deployed to Preview – live-common-tools July 26, 2022 11:14 View deployment

vercel bot deployed to Preview – live-common-tools July 26, 2022 12:00 View deployment

jules-grenier-ledger and others added 7 commits July 26, 2022 16:28

LIVE-2542 - Prompt notif choice tracking

35a9757

LIVE-2542 - Notif settings access tracking

c5f4038

LIVE-2542 - Notif settings toggles tracking

15b6c4a

LIVE-2542 - Notif settings navigation tracking

adbe26e

feat/LIVE-2542-push-notif-analytics PromptNotification file removed

0123750

feat/LIVE-2542-push-notif-analytics tracking done

0caee20

feat/LIVE-2542-push-notif-analytics tracking done

afaf39d

cgrellard-ledger force-pushed the feat/LIVE-2536-llm-notifications-prompts branch from 46da5ec to afaf39d Compare July 26, 2022 14:29

vercel bot deployed to Preview – live-common-tools July 26, 2022 14:32 View deployment

cgrellard-ledger added the feature ready label Jul 26, 2022

feat/LIVE-2536-llm-notifications-prompts changeset added

3bdbfd3

vercel bot deployed to Preview – live-common-tools July 27, 2022 08:35 View deployment

feat/LIVE-2536-llm-notifications-prompts fix bug when push notificati…

b1dce36

…ons feature flag is disabled

vercel bot deployed to Preview – live-common-tools July 27, 2022 12:27 View deployment

thomasrogerlux changed the base branch from develop to release July 28, 2022 15:31

Merge branch 'release' of github.com:LedgerHQ/ledger-live into feat/L…

09dfd32

…IVE-2536-llm-notifications-prompts

vercel bot deployed to Preview – live-common-tools July 28, 2022 15:56 View deployment

vercel bot deployed to Preview – ledger-live-github-bot July 28, 2022 15:56 View deployment

vercel bot deployed to Preview – react-ui-storybook July 28, 2022 15:58 View deployment

vercel bot deployed to Preview – native-ui-storybook July 28, 2022 16:02 View deployment

fix lint

852cd7f

vercel bot deployed to Preview – live-common-tools July 28, 2022 16:51 View deployment

Merge branch 'release' of github.com:LedgerHQ/ledger-live into feat/L…

671a3fd

…IVE-2536-llm-notifications-prompts

vercel bot deployed to Preview – native-ui-storybook July 29, 2022 07:21 View deployment

vercel bot deployed to Preview – live-common-tools July 29, 2022 07:24 View deployment

LFBarreto merged commit b7a4dcf into release Jul 29, 2022

LFBarreto deleted the feat/LIVE-2536-llm-notifications-prompts branch July 29, 2022 07:56

desirendr added this to the Ledger Live Mobile 3.5.x milestone Jul 29, 2022

ofreyssinet-ledger mentioned this pull request Aug 17, 2022

Fix (LLM): getFeature being a hook & called as a regular function #958

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LLM notifications prompts #507

LLM notifications prompts #507

jules-grenier-ledger commented Jun 28, 2022 •

edited by jira bot

Loading

vercel bot commented Jun 28, 2022 •

edited

Loading

changeset-bot bot commented Jun 28, 2022 •

edited

Loading

github-actions bot commented Jul 20, 2022 •

edited

Loading

codecov bot commented Jul 20, 2022 •

edited

Loading

LFBarreto left a comment

LFBarreto Jul 20, 2022

gre commented Jul 28, 2022

LLM notifications prompts #507

LLM notifications prompts #507

Conversation

jules-grenier-ledger commented Jun 28, 2022 • edited by jira bot Loading

📝 Description

❓ Context

✅ Checklist

📸 Demo

🚀 Expectations to reach

vercel bot commented Jun 28, 2022 • edited Loading

changeset-bot bot commented Jun 28, 2022 • edited Loading

🦋 Changeset detected

github-actions bot commented Jul 20, 2022 • edited Loading

codecov bot commented Jul 20, 2022 • edited Loading

Codecov Report

LFBarreto left a comment

Choose a reason for hiding this comment

LFBarreto Jul 20, 2022

Choose a reason for hiding this comment

gre commented Jul 28, 2022

jules-grenier-ledger commented Jun 28, 2022 •

edited by jira bot

Loading

vercel bot commented Jun 28, 2022 •

edited

Loading

changeset-bot bot commented Jun 28, 2022 •

edited

Loading

github-actions bot commented Jul 20, 2022 •

edited

Loading

codecov bot commented Jul 20, 2022 •

edited

Loading