Bridge with mocks testing #5803

hedi-edelbloute · 2023-12-22T17:18:26Z

📝 Description

Adds workflows on PRs that uses mocked version of backend to be more stable (and required)
Bridge test support will be enabled step by step on each currency, supported currencies are listed in jest config

To run bridge test using mocks :
pnpm run test-bridge

To update mocks :
pnpm run test-bridge-update

Supported : algorand

Cosmos should already be supported but there is an issue on develop

Families that require specific work :

EVM, celo, ripple : post parameters support
Near, tron : parameter than changes each run (date for near, fingerprint for tron)

❓ Context

JIRA or GitHub link: https://ledgerhq.atlassian.net/browse/LIVE-8439

✅ Checklist

Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.

npx changeset was attached.
Covered by automatic tests.
[ ] Impact of the changes:

🧐 Checklist for the PR Reviewers

The code aligns with the requirements described in the linked JIRA or GitHub issue.
The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
There are no undocumented trade-offs, technical debt, or maintainability issues.
The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
Any new dependencies have been justified and documented.
Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

vercel · 2023-12-22T17:18:35Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments

Name	Status	Preview	Updated (UTC)
ledger-live-docs	⬜️ Ignored (Inspect)	Visit Preview	Feb 6, 2024 4:09pm
ledger-live-github-bot	⬜️ Ignored (Inspect)	Visit Preview	Feb 6, 2024 4:09pm
native-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview	Feb 6, 2024 4:09pm
react-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview	Feb 6, 2024 4:09pm
web-tools	⬜️ Ignored (Inspect)	Visit Preview	Feb 6, 2024 4:09pm

github-actions · 2024-01-07T04:24:29Z

There as been no activity on this PR for the last 14 days. Please consider closing this PR.

libs/ledger-live-common/src/__tests__/test-helpers/bridge.ts

libs/ledger-live-common/package.json

libs/ledger-live-common/src/__tests__/test-helpers/bridgeSetupUpdateMocks.ts

vercel · 2024-01-30T17:29:52Z

Deployment failed with the following error:

Too many requests - try again in 1 minute (more than 60, code: "api-deployments-flood").

sprohaszka-ledger

LGTM

sprohaszka-ledger

There are some linters errors :/

KVNLS

Great work!

.github/workflows/test-bridge-pr.yml

libs/ledger-live-common/src/__tests__/test-helpers/bridgeTeardownUpdateMocks.ts

hzheng-ledger · 2024-02-07T13:37:27Z

libs/ledger-live-common/jest.config.ts

@@ -18,6 +18,15 @@ if (process.env.ONLY_INTEGRATION_TESTS) {
 testRegex = "(/__tests__/.*|(\\.|/)integration\\.(test|spec))\\.[jt]sx?$";
 }

+if (process.env.USE_BACKEND_MOCKS) {


the name is a little confusing here.
should we use kind of "process.env.ONLY_BRIDGE_TESTS" to filter the bridge integration tests?

Indeed, we could update the name as now it's "bridge tests"

hzheng-ledger · 2024-02-07T13:44:14Z

libs/ledger-live-common/.ci.bridge.env

@@ -0,0 +1,3 @@
+DISABLE_MOCKED_WARNING=true
+API_STELLAR_HORIZON_STATIC_FEE=true


It is not directly related to the PR.
but it seems that the

if (getEnv("API_STELLAR_HORIZON_STATIC_FEE")) {

in "src/families/stellar/api/horizon.ts"

could be replaced by something like

if (process.env.TESTING)

It could save the env var "API_STELLAR_HORIZON_STATIC_FEE"

Ok thanks i'm going to check :)

hzheng-ledger · 2024-02-07T13:47:19Z

libs/ledger-live-common/package.json

@@ -70,6 +70,8 @@
 "test": "pnpm ci-test-unit",
 "ci-test-unit": "env-cmd -f .ci.unit.env pnpm jest --ci --updateSnapshot && git diff --exit-code src",
 "ci-test-integration": "env-cmd -f .ci.integration.env pnpm jest --ci --updateSnapshot --passWithNoTests",
+ "test-bridge": "env-cmd -f .ci.bridge.env pnpm jest --ci --updateSnapshot --passWithNoTests --runInBand",


just a question, should we still need "updateSnapshot" for "test-bridge" and "test-bridge-update" as we've mocked the http responses now ?

🤔 Indeed we could restrict to standard integration bridge test

hzheng-ledger · 2024-02-07T13:52:21Z

libs/ledger-live-common/src/__tests__/test-helpers/bridgeSetupUpdateMocks.ts

+import { createHash } from "crypto";
+
+function sha256(str: string) {
+ return createHash("sha256").update(str).digest("hex");


I think base64 is enough. I we don't really need sha256 to encode it.

Oh ok, will try :)

hzheng-ledger · 2024-02-07T13:53:52Z

libs/ledger-live-common/src/__tests__/test-helpers/bridgeSetupUpdateMocks.ts

+ url: nodeRequest.url,
+ headers: nodeRequest.headers,
+ body: nodeRequest.body != null ? nodeRequest.body : {},
+ fileName: sha256(`${nodeRequest.method}${nodeRequest.url}`),


maybe we can exclude the hostname of nodeRequest.url because we may change the RPC node from time to time but we want to keep the filename I think.

I add something related to this in improvements, this is to think about as a lot of parameters could impact responses (client version, feature support, min blockheight for history, ...)

hzheng-ledger · 2024-02-07T13:55:52Z

libs/ledger-live-common/src/__tests__/test-helpers/bridgeSetupUseMocks.ts

+
+/* Loop through each mock and apply them to nock */
+export async function initBackendMocks() {
+ const root = `${__dirname}/bridgeMocks`;


Should we categorise files into different sub folders by family or coin instead of putting all mock files in a single folder?

I tried but since we are "sniffing" globally we either have to :

Find the impacted family using url (not clean)

Doing mock updates by chain only

It is a choice but indeed that way it would be cleaner and easier to deal with

Do you think of a better solution ?

yes, I see.
Maybe keep it like this at the moment and think about improvements later.

Bridge with mocks testing

github-actions bot assigned hedi-edelbloute Dec 22, 2023

live-github-bot bot added the common Has changes in live-common label Dec 22, 2023

github-actions bot added the Stale label Jan 7, 2024

github-actions bot closed this Jan 14, 2024

hedi-edelbloute reopened this Jan 19, 2024

vercel bot deployed to Preview – web-tools January 19, 2024 09:05 View deployment

vercel bot deployed to Preview – web-tools January 23, 2024 14:22 View deployment

vercel bot deployed to Preview – web-tools January 24, 2024 09:01 View deployment

vercel bot had a problem deploying to Preview – web-tools January 26, 2024 16:40 Failure

vercel bot had a problem deploying to Preview – web-tools January 30, 2024 09:16 Failure

vercel bot had a problem deploying to Preview – web-tools January 30, 2024 09:19 Failure

ghost reviewed Jan 30, 2024

View reviewed changes

libs/ledger-live-common/src/__tests__/test-helpers/bridge.ts Outdated Show resolved Hide resolved

libs/ledger-live-common/package.json Outdated Show resolved Hide resolved

libs/ledger-live-common/src/__tests__/test-helpers/bridgeSetupUpdateMocks.ts Show resolved Hide resolved

live-github-bot bot added the automation CI/CD stuff label Jan 30, 2024

vercel bot had a problem deploying to Preview – web-tools January 30, 2024 17:17 Failure

hedi-edelbloute force-pushed the support/bridge-integration-rework branch from 976679c to 19bf70c Compare January 30, 2024 17:21

hedi-edelbloute marked this pull request as ready for review January 30, 2024 17:21

hedi-edelbloute requested review from a team as code owners January 30, 2024 17:21

vercel bot had a problem deploying to Preview – web-tools January 30, 2024 17:23 Failure

hedi-edelbloute force-pushed the support/bridge-integration-rework branch from 3f9869f to b81ce81 Compare January 30, 2024 17:29

vercel bot had a problem deploying to Preview – web-tools January 30, 2024 17:37 Failure

vercel bot deployed to Preview – web-tools January 30, 2024 18:53 View deployment

vercel bot deployed to Preview – web-tools January 30, 2024 19:18 View deployment

vercel bot deployed to Preview – web-tools January 31, 2024 07:35 View deployment

vercel bot deployed to Preview – web-tools January 31, 2024 08:15 View deployment

vercel bot had a problem deploying to Preview – web-tools January 31, 2024 08:53 Failure

vercel bot deployed to Preview – web-tools February 1, 2024 08:55 View deployment

remove filter

7095392

sprohaszka-ledger approved these changes Feb 5, 2024

View reviewed changes

sprohaszka-ledger reviewed Feb 5, 2024

View reviewed changes

sprohaszka-ledger self-requested a review February 5, 2024 16:34

sprohaszka-ledger previously approved these changes Feb 5, 2024

View reviewed changes

KVNLS previously approved these changes Feb 6, 2024

View reviewed changes

.github/workflows/test-bridge-pr.yml Outdated Show resolved Hide resolved

libs/ledger-live-common/src/__tests__/test-helpers/bridgeTeardownUpdateMocks.ts Outdated Show resolved Hide resolved

remove useless deletes and var

08cdaae

hedi-edelbloute dismissed stale reviews from KVNLS and sprohaszka-ledger via 08cdaae February 6, 2024 10:13

hedi-edelbloute added 2 commits February 6, 2024 11:14

run only on ubuntu

cb2fc4f

trigger on algorand

bc0e8fa

vercel bot deployed to Preview – web-tools February 6, 2024 11:10 View deployment

hedi-edelbloute added 2 commits February 6, 2024 12:10

fix ci

3e89891

remove algorand diff

d6dc15f

vercel bot had a problem deploying to Preview – web-tools February 6, 2024 12:52 Failure

add changeset

bd4ee6c

KVNLS approved these changes Feb 6, 2024

View reviewed changes

sprohaszka-ledger approved these changes Feb 7, 2024

View reviewed changes

ghost approved these changes Feb 7, 2024

View reviewed changes

hedi-edelbloute merged commit caedccf into develop Feb 7, 2024
62 of 63 checks passed

hedi-edelbloute deleted the support/bridge-integration-rework branch February 7, 2024 12:26

hzheng-ledger reviewed Feb 7, 2024

View reviewed changes

jdabbech-ledger pushed a commit that referenced this pull request Feb 19, 2024

Merge pull request #5803 from LedgerHQ/support/bridge-integration-rework

734f992

Bridge with mocks testing

jdabbech-ledger pushed a commit that referenced this pull request Feb 19, 2024

Merge pull request #5803 from LedgerHQ/support/bridge-integration-rework

13be813

Bridge with mocks testing

Wozacosta mentioned this pull request Aug 30, 2024

LIVE-8168 Support/coin cosmos module #7636

Merged

51 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bridge with mocks testing #5803

Bridge with mocks testing #5803

hedi-edelbloute commented Dec 22, 2023 •

edited

Loading

vercel bot commented Dec 22, 2023 •

edited

Loading

github-actions bot commented Jan 7, 2024

vercel bot commented Jan 30, 2024

sprohaszka-ledger left a comment

sprohaszka-ledger left a comment

KVNLS left a comment

hzheng-ledger Feb 7, 2024

hedi-edelbloute Feb 7, 2024

hzheng-ledger Feb 7, 2024 •

edited

Loading

hedi-edelbloute Feb 7, 2024

hzheng-ledger Feb 7, 2024

hedi-edelbloute Feb 7, 2024

hzheng-ledger Feb 7, 2024

hedi-edelbloute Feb 7, 2024

hzheng-ledger Feb 7, 2024 •

edited

Loading

hedi-edelbloute Feb 7, 2024

hzheng-ledger Feb 8, 2024

hzheng-ledger Feb 7, 2024

hedi-edelbloute Feb 7, 2024

hzheng-ledger Feb 8, 2024

		@@ -0,0 +1,3 @@
		DISABLE_MOCKED_WARNING=true
		API_STELLAR_HORIZON_STATIC_FEE=true

Bridge with mocks testing #5803

Bridge with mocks testing #5803

Conversation

hedi-edelbloute commented Dec 22, 2023 • edited Loading

📝 Description

❓ Context

✅ Checklist

[ ] Impact of the changes:

🧐 Checklist for the PR Reviewers

vercel bot commented Dec 22, 2023 • edited Loading

github-actions bot commented Jan 7, 2024

vercel bot commented Jan 30, 2024

sprohaszka-ledger left a comment

Choose a reason for hiding this comment

sprohaszka-ledger left a comment

Choose a reason for hiding this comment

KVNLS left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hzheng-ledger Feb 7, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hzheng-ledger Feb 7, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hedi-edelbloute commented Dec 22, 2023 •

edited

Loading

vercel bot commented Dec 22, 2023 •

edited

Loading

hzheng-ledger Feb 7, 2024 •

edited

Loading

hzheng-ledger Feb 7, 2024 •

edited

Loading