feat: clarify error message for invalid address selected #5833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
live-github-bot
bot
added
common
CremaFR
reviewed
Jan 4, 2024
Comment on lines
32
to
36
| case ErrorStatus.INVALID_ADDRESS: | ||
| return "Invalid address"; | ||
| case ErrorStatus.USER_REFUSED: | ||
| return "User refused"; | ||
| if (step === "CHECK_PAYOUT_ADDRESS") | ||
| return "This receiving account does not belong to your device. Please change and retry." | ||
| else if (step === "CHECK_REFUND_ADDRESS") | ||
| return "This receiving account does not belong to your device for the refund. Please change and retry."; |
There was a problem hiding this comment.
Shouldn't you fallback to the previous error? And this step checks was on INVALID_ADDRESS, not USER_REFUSED iirc?
kallen-ledger
previously approved these changes
Jan 8, 2024
lpaquet-ledger
force-pushed
the
feat/LIVE-9693-invalid-address-error
branch
from
c1c7ab1
to
0e9ab46
Compare
lpaquet-ledger
force-pushed
the
feat/LIVE-9693-invalid-address-error
branch
2 times, most recently
from
73dc122
to
d990a5b
Compare
lpaquet-ledger
force-pushed
the
feat/LIVE-9693-invalid-address-error
branch
from
d990a5b
to
54a6174
Compare
CremaFR
previously approved these changes
Feb 2, 2024
kallen-ledger
previously approved these changes
Feb 2, 2024
lpaquet-ledger
force-pushed
the
feat/LIVE-9693-invalid-address-error
branch
from
9d655b2
to
00cbb14
Compare
lpaquet-ledger
dismissed stale reviews from kallen-ledger and CremaFR
via
7719d49
lpaquet-ledger
force-pushed
the
feat/LIVE-9693-invalid-address-error
branch
from
7719d49
to
cadd9d7
Compare
lpaquet-ledger
force-pushed
the
feat/LIVE-9693-invalid-address-error
branch
from
cadd9d7
to
2136eed
Compare
lpaquet-ledger
force-pushed
the
feat/LIVE-9693-invalid-address-error
branch
from
2136eed
to
ed1c753
Compare
ghost
approved these changes
Feb 7, 2024
jdabbech-ledger
pushed a commit
that referenced
this pull request
Feb 19, 2024
…-error feat: clarify error message for invalid address selected
jdabbech-ledger
pushed a commit
that referenced
this pull request
Feb 19, 2024
…-error feat: clarify error message for invalid address selected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
clarify error message for invalid address selected
Add two different messages if the error happens at two different steps
❓ Context
https://ledgerhq.atlassian.net/browse/LIVE-9693
✅ Checklist
Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.
npx changesetwas attached.[ ] Impact of the changes:
🧐 Checklist for the PR Reviewers