Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support: fix RemoteLiveAppProvider not updating if env changes [LIVE-11200] #6087

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

Justkant
Copy link
Contributor

@Justkant Justkant commented Feb 5, 2024

📝 Description

Fix RemoteLiveAppProvider not updating if env changes

❓ Context

✅ Checklist

Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.

  • npx changeset was attached.
  • Covered by automatic tests. Nop used for debug
  • Impact of the changes:
    • Discover section
    • Debug discover and live-apps

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@Justkant Justkant requested a review from a team as a code owner February 5, 2024 14:57
@Justkant Justkant self-assigned this Feb 5, 2024
Copy link

vercel bot commented Feb 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2024 10:13am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2024 10:13am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2024 10:13am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2024 10:13am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2024 10:13am

@Justkant Justkant merged commit b43ef05 into develop Feb 7, 2024
58 of 59 checks passed
@Justkant Justkant deleted the support/fix-remote-live-app-provider-env branch February 7, 2024 11:11
@Justkant Justkant changed the title support: fix RemoteLiveAppProvider not updating if env changes support: fix RemoteLiveAppProvider not updating if env changes [LIVE-11200] Feb 7, 2024
jdabbech-ledger pushed a commit that referenced this pull request Feb 19, 2024
…ovider-env

support: fix RemoteLiveAppProvider not updating if env changes
jdabbech-ledger pushed a commit that referenced this pull request Feb 19, 2024
…ovider-env

support: fix RemoteLiveAppProvider not updating if env changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants