Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LLD - Fixed accounts order after changing countervalue in the settings #6096

Merged

Conversation

cgrellard-ledger
Copy link
Contributor

@cgrellard-ledger cgrellard-ledger commented Feb 6, 2024

📝 Description

LLD - Fixed accounts order after changing countervalue in the settings

BEFORE

Screen.Recording.2024-02-06.at.17.13.15.mov

AFTER

Screen.Recording.2024-02-06.at.16.50.15.mov

❓ Context

✅ Checklist

Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@cgrellard-ledger cgrellard-ledger requested a review from a team as a code owner February 6, 2024 08:58
Copy link

vercel bot commented Feb 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Feb 8, 2024 10:04am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Feb 8, 2024 10:04am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 8, 2024 10:04am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 8, 2024 10:04am
web-tools ⬜️ Ignored (Inspect) Visit Preview Feb 8, 2024 10:04am

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Feb 6, 2024
@cgrellard-ledger
Copy link
Contributor Author

cgrellard-ledger commented Feb 7, 2024

@cgrellard-ledger

Generating screenshots: workflow ended

Jobs status:
✅ - generate-screenshots-windows
✅ - generate-screenshots-linux
✅ - generate-screenshots-mac

@cgrellard-ledger cgrellard-ledger requested a review from a team as a code owner February 7, 2024 10:14
@live-github-bot live-github-bot bot added the screenshots Screenshots have been updated label Feb 7, 2024
@cgrellard-ledger
Copy link
Contributor Author

cgrellard-ledger commented Feb 7, 2024

@cgrellard-ledger

Generating screenshots: workflow ended

Jobs status:
✅ - generate-screenshots-windows
✅ - generate-screenshots-mac
✅ - generate-screenshots-linux

@cgrellard-ledger
Copy link
Contributor Author

cgrellard-ledger commented Feb 8, 2024

@cgrellard-ledger

Generating screenshots: workflow started

@live-github-bot live-github-bot bot added the screenshots Screenshots have been updated label Feb 8, 2024
@cgrellard-ledger cgrellard-ledger merged commit 9180450 into develop Feb 8, 2024
34 checks passed
@cgrellard-ledger cgrellard-ledger deleted the bugfix/lld-accounts-order-after-settings-change branch February 8, 2024 10:44
jdabbech-ledger pushed a commit that referenced this pull request Feb 19, 2024
…r-settings-change

LLD - Fixed accounts order after changing countervalue in the settings
jdabbech-ledger pushed a commit that referenced this pull request Feb 19, 2024
…r-settings-change

LLD - Fixed accounts order after changing countervalue in the settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD screenshots Screenshots have been updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants