Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Release LLD - Underline a tags in Alert messages #6211

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

KVNLS
Copy link
Member

@KVNLS KVNLS commented Feb 15, 2024

πŸ“ Description

We want elements to be styled with underline and cursor pointer.

After
image

❓ Context

  • JIRA or GitHub link:

βœ… Checklist

Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@KVNLS KVNLS self-assigned this Feb 15, 2024
Copy link

vercel bot commented Feb 15, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Feb 15, 2024 2:44pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Feb 15, 2024 2:44pm
native-ui-storybook ⬜️ Ignored (Inspect) Feb 15, 2024 2:44pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 15, 2024 2:44pm
web-tools ⬜️ Ignored (Inspect) Feb 15, 2024 2:44pm

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Feb 15, 2024
@KVNLS KVNLS marked this pull request as ready for review February 15, 2024 15:00
@KVNLS KVNLS requested a review from a team as a code owner February 15, 2024 15:00
@KVNLS KVNLS merged commit 49e7e5c into release Feb 15, 2024
36 checks passed
@KVNLS KVNLS deleted the fix/underline-a-in-alert-release branch February 15, 2024 15:09
jdabbech-ledger pushed a commit that referenced this pull request Feb 19, 2024
Fix Release LLD - Underline a tags in Alert messages
jdabbech-ledger pushed a commit that referenced this pull request Feb 19, 2024
Fix Release LLD - Underline a tags in Alert messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants