Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support/near hotfix #6279

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Support/near hotfix #6279

merged 2 commits into from
Feb 21, 2024

Conversation

hedi-edelbloute
Copy link
Member

πŸ“ Description

apply #6268 content to hotfix branch via cherry pick

❓ Context

βœ… Checklist

Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@hedi-edelbloute hedi-edelbloute requested review from a team as code owners February 21, 2024 13:59
@live-github-bot live-github-bot bot added the ledgerjs Has changes in the ledgerjs open source libs label Feb 21, 2024
Copy link

vercel bot commented Feb 21, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Ignored Deployments
Name Status Preview Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Feb 21, 2024 1:59pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Feb 21, 2024 1:59pm
native-ui-storybook ⬜️ Ignored (Inspect) Feb 21, 2024 1:59pm
react-ui-storybook ⬜️ Ignored (Inspect) Feb 21, 2024 1:59pm
web-tools ⬜️ Ignored (Inspect) Feb 21, 2024 1:59pm

@hedi-edelbloute hedi-edelbloute merged commit d4bf8e3 into hotfix Feb 21, 2024
22 of 24 checks passed
@hedi-edelbloute hedi-edelbloute deleted the support/near-hotfix branch February 21, 2024 14:00
@live-github-bot
Copy link
Contributor

Mobile Bundle Checks

Comparing 3e28615 against 18e0d6c.

⚠️ main.ios.jsbundle bundle size significantly increased: 57.9mb -> 58.2mb. Please check if this is expected.
⚠️ main.android.jsbundle bundle size significantly increased: 57.9mb -> 58.2mb. Please check if this is expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ledgerjs Has changes in the ledgerjs open source libs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants