Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 Hotfix merge conflicts #6295

Merged
merged 432 commits into from
Feb 23, 2024
Merged

Conversation

live-github-bot[bot]
Copy link
Contributor

The hotfix had some merge conflicts 🚨

This pull request was created in order to resolve the merge conflicts between the hotfix and develop branches.

git checkout develop && git pull

git checkout support/hotfix-merge-conflicts

git merge develop

Checklist

To be ready to be merged, we must comply with all theses checks:

  • all CI checks have passed
  • reviews of the code owners impacted by the conflict

⚠️ Warning ⚠️

Warning
Only merge the PR with the option Create a merge commit

beths-ledger and others added 30 commits February 19, 2024 16:55
[LIVE-10878] App Store Developer Name Display
* btc doc

* btc doc

* btc doc

* btc doc

* btc doc

* btc doc

* add changeset

* btc doc

* fix: update btc doc

* fix: update btc doc
* Draft simpleHash usage

* Remove spread

* commit pnpm

* Reorg hook 🪝

* Fixed Types

* Fix loading and type issue

* remove fake color

* WIP

* Improvment

* test: add useNftGalleryFilter test

* Add FF

* Fix unimported in lib

* [FEAT]: use simpleHash for LLD Gallery (#6042)

* Add changeset

* chore: move the api endpoint into its env

* Review

* Try new SPAM_FILTER_THRESHOLD

* FIX e2E tests

* fix test

---------

Co-authored-by: Gaëtan Renaudeau <renaudeau.gaetan@gmail.com>
Remove playwright replay on macOS and Windows
[LLD] - [LIVE-10488] - Add Portfolio Content Card
* fix(deps): update dependency @dfinity/agent to v0.21.4

* fix: bot

---------

Co-authored-by: live-github-bot[bot] <105061298+live-github-bot[bot]@users.noreply.github.com>
Co-authored-by: Gaëtan Renaudeau <renaudeau.gaetan@gmail.com>
@live-github-bot live-github-bot bot added tools Has changes in tools automation CI/CD stuff translations Translation files have been touched screenshots Screenshots have been updated cli labels Feb 23, 2024
Copy link

socket-security bot commented Feb 23, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@abandonware/noble@1.9.2-23 environment 0 1.33 MB rzr
npm/@actions/cache@3.0.4 environment, filesystem Transitive: network, shell +15 11.4 MB thboop
npm/@actions/core@1.10.1 environment, filesystem Transitive: network +1 149 kB thboop
npm/@actions/github@6.0.0 environment, filesystem Transitive: network +1 94.4 kB thboop
npm/@aws-sdk/client-s3@3.370.0 Transitive: environment, filesystem, shell +48 5.47 MB aws-sdk-bot
npm/@azure/core-asynciterator-polyfill@1.0.2 None 0 6.51 kB azure-sdk
npm/@babel/core@7.22.8 environment, filesystem, unsafe +24 9.74 MB nicolo-ribaudo
npm/@babel/core@7.23.2 environment, filesystem, unsafe +24 9.75 MB nicolo-ribaudo
npm/@babel/generator@7.17.10 Transitive: environment +3 2.65 MB nicolo-ribaudo
npm/@babel/plugin-proposal-class-properties@7.16.7 Transitive: environment, filesystem, unsafe +31 9.94 MB nicolo-ribaudo
npm/@babel/plugin-proposal-export-namespace-from@7.16.7 Transitive: environment, filesystem, unsafe +27 9.78 MB nicolo-ribaudo
npm/@babel/plugin-transform-class-static-block@7.23.4 Transitive: environment, filesystem, unsafe +30 9.84 MB nicolo-ribaudo
npm/@babel/preset-env@7.17.10 environment Transitive: filesystem, unsafe +104 20.3 MB nicolo-ribaudo
npm/@babel/preset-react@7.16.7 Transitive: environment, filesystem, unsafe +30 9.79 MB nicolo-ribaudo
npm/@babel/preset-react@7.22.15 Transitive: environment, filesystem, unsafe +27 9.78 MB nicolo-ribaudo
npm/@babel/preset-react@7.23.3 Transitive: environment, filesystem, unsafe +29 9.78 MB nicolo-ribaudo
npm/@babel/preset-typescript@7.23.3 Transitive: environment, filesystem, unsafe +30 9.85 MB nicolo-ribaudo
npm/@babel/runtime@7.17.9 None 0 173 kB nicolo-ribaudo
npm/@babel/runtime@7.22.10 None 0 282 kB nicolo-ribaudo
npm/@braze/react-native-sdk@8.0.0 None 0 252 kB appboy
npm/@braze/web-sdk@4.6.3 None 0 415 kB appboy
npm/@cardano-foundation/ledgerjs-hw-app-cardano@6.0.1 None 0 633 kB jan.mazak
npm/@celo/connect@3.0.1 None +2 811 kB alecps
npm/@celo/contractkit@3.0.1 filesystem, network +3 3.66 MB alecps
npm/@celo/utils@3.0.1 None +1 700 kB alecps
npm/@celo/wallet-base@3.0.1 None +3 853 kB alecps
npm/@celo/wallet-ledger@3.0.1 None +5 930 kB alecps
npm/@changesets/changelog-github@0.5.0 Transitive: environment, network +2 98 kB changesets-release-bot
npm/@changesets/cli@2.26.0 environment, filesystem, shell +16 1.12 MB changesets-release-bot
npm/@commitlint/cli@17.4.2 Transitive: environment, filesystem +15 278 kB escapedcat
npm/@commitlint/config-conventional@17.6.5 None 0 9.6 kB escapedcat
npm/@commitlint/prompt-cli@17.4.2 Transitive: environment +7 154 kB escapedcat
npm/@cosmjs/amino@0.31.1 None +4 302 kB webmaster128
npm/@cosmjs/crypto@0.31.0 None +3 213 kB webmaster128
npm/@cosmjs/stargate@0.26.6 Transitive: network +11 2.98 MB webmaster128
npm/@craftamap/esbuild-plugin-html@0.6.1 filesystem 0 26.7 kB craftamap
npm/@crypto-org-chain/chain-jslib@1.1.2 Transitive: network +22 10.5 MB calvinaco
npm/@dfinity/agent@0.21.4 network +2 2.06 MB krpeacock
npm/@dfinity/candid@0.21.4 None +1 787 kB krpeacock
npm/@dfinity/principal@0.15.6 None 0 140 kB krpeacock
npm/@electron/notarize@2.2.1 filesystem, shell 0 63.5 kB electron-cfa
npm/@elrondnetwork/erdjs-network-providers@1.2.0 None 0 179 kB andreibancioiu
npm/@elrondnetwork/erdjs@11.0.0 None +1 629 kB lucian.mincu
npm/@emotion/core@11.0.0 environment 0 17.1 kB emotion-release-bot
npm/@emotion/native@11.11.0 environment +1 75.3 kB emotion-release-bot
npm/@ethersproject/abi@5.6.1 Transitive: network +19 1.86 MB ricmoo
npm/@ethersproject/rlp@5.6.0 None +2 180 kB ricmoo
npm/@ethersproject/shims@5.7.0 None 0 452 kB ricmoo
npm/@expo/metro-config@0.10.7 environment, eval, filesystem +10 1.93 MB evanbacon
npm/@expo/webpack-config@18.1.3 environment, filesystem Transitive: unsafe +25 10.2 MB brentvatne
npm/@ledgerhq/coin-framework@0.11.2 None +6 62.1 MB aboissiere, gbrahm-ledger, ldg-github-ci, ...4 more
npm/@ledgerhq/crypto-icons-ui@1.0.2 None 0 5.99 MB ldg-github-ci
npm/@ledgerhq/cryptoassets@11.4.1 None 0 59.6 MB aboissiere, gbrahm-ledger, ldg-github-ci, ...4 more
npm/@ledgerhq/devices@8.2.1 None +2 430 kB aboissiere, gbrahm-ledger, ldg-github-ci, ...4 more
npm/@ledgerhq/domain-service@1.1.18 None +3 843 kB ldg-github-ci
npm/@ledgerhq/errors@6.16.2 None 0 189 kB aboissiere, gbrahm-ledger, ldg-github-ci, ...4 more
npm/@ledgerhq/evm-tools@1.0.16 None +1 59.7 MB ldg-github-ci
npm/@ledgerhq/hw-app-eth@6.35.6 Transitive: network +30 64.9 MB aboissiere, gbrahm-ledger, ldg-github-ci, ...4 more
npm/@ledgerhq/hw-transport-http@6.29.4 network +4 632 kB ldg-github-ci
npm/@ledgerhq/hw-transport-mocker@6.28.4 None +4 661 kB aboissiere, gbrahm-ledger, ldg-github-ci, ...4 more
npm/@ledgerhq/hw-transport-node-hid-noevents@6.29.4 None +4 622 kB ldg-github-ci
npm/@ledgerhq/hw-transport-node-speculos-http@6.28.4 None +4 601 kB ldg-github-ci
npm/@ledgerhq/hw-transport-node-speculos@6.28.4 network +4 612 kB ldg-github-ci
npm/@ledgerhq/hw-transport@6.30.4 None +3 556 kB aboissiere, gbrahm-ledger, ldg-github-ci, ...4 more
npm/@ledgerhq/icons-ui@0.6.2 None 0 3.73 MB sergii-shkolin
npm/@ledgerhq/live-common@33.6.1 Transitive: filesystem, network +97 123 MB aboissiere, gbrahm-ledger, ldg-github-ci, ...4 more
npm/@ledgerhq/live-countervalues@0.1.2 None +9 62.7 MB ldg-github-ci
npm/@ledgerhq/live-hooks@0.1.0 None 0 13.7 kB ldg-github-ci
npm/@ledgerhq/live-network@1.1.13 None +3 335 kB ldg-github-ci
npm/@ledgerhq/live-nft@0.2.1 None +9 62.3 MB ldg-github-ci
npm/@ledgerhq/live-promise@0.0.3 None +1 67.2 kB sergii-shkolin
npm/@ledgerhq/logs@6.12.0 None 0 36.3 kB sergii-shkolin
npm/@ledgerhq/native-ui@0.22.7 None +3 11.6 MB ldg-github-ci
npm/@ledgerhq/react-ui@0.14.15 None +3 13.3 MB ldg-github-ci
npm/@ledgerhq/swift-bridge-hw-transport-ble@1.1.4 None +4 575 kB ldg-github-ci
npm/@ledgerhq/types-cryptoassets@7.9.0 None 0 71.2 kB ldg-github-ci
npm/@ledgerhq/types-devices@6.23.0 None 0 29 kB sergii-shkolin
npm/@ledgerhq/types-live@6.44.1 None 0 476 kB ldg-github-ci
npm/@ledgerhq/ui-shared@0.2.1 None 0 47.1 kB sergii-shkolin

🚮 Removed packages: npm/@octokit/rest@18.12.0, npm/@types/lodash@4.14.182, npm/@types/qs@6.9.7, npm/async@3.2.3, npm/axios@0.25.0, npm/axios@0.26.1, npm/axios@0.27.2, npm/buffer@6.0.3, npm/camelcase@6.3.0, npm/chalk@4.1.2, npm/cors@2.8.5, npm/date-fns@2.28.0, npm/debug@4.3.4, npm/events@3.3.0, npm/imurmurhash@0.1.4, npm/invariant@2.2.4, npm/listr@0.14.3, npm/lodash@4.17.21, npm/long@4.0.0, npm/mkdirp@1.0.4, npm/moment@2.29.3, npm/performance-now@2.1.0, npm/prop-types@15.8.1, npm/qs@6.10.3, npm/react-dom@18.2.0, npm/react@18.2.0, npm/regenerator-runtime@0.14.0, npm/semver@7.5.4, npm/sha.js@2.4.11, npm/source-map-support@0.5.21, npm/tree-kill@1.2.2, npm/triple-beam@1.3.0, npm/tslib@2.6.2, npm/uuid@8.3.2, npm/uuid@9.0.0, npm/uuid@9.0.1

View full report↗︎

@live-github-bot
Copy link
Contributor Author

live-github-bot bot commented Feb 23, 2024

Mobile Bundle Checks

Comparing c32435e against e7bff4e.

⚠️ main.ios.jsbundle bundle size significantly increased: 58mb -> 58.6mb. Please check if this is expected.
⚠️ main.android.jsbundle bundle size significantly increased: 58mb -> 58.7mb. Please check if this is expected.

Desktop Bundle Checks

Comparing c32435e against e7bff4e.

⚠️ renderer bundle size significantly increased: 36mb -> 36.6mb. Please check if this is expected.

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Native code npm/@abandonware/bluetooth-hci-socket@0.5.3-10
  • orphan: npm/@abandonware/bluetooth-hci-socket@0.5.3-10
Install scripts npm/@abandonware/bluetooth-hci-socket@0.5.3-10
  • Install script: install
  • Source: node-pre-gyp install --fallback-to-build --update-binary
  • orphan: npm/@abandonware/bluetooth-hci-socket@0.5.3-10
Native code npm/@abandonware/noble@1.9.2-23

View full report↗︎

Next steps

What's wrong with native code?

Contains native code which could be a vector to obscure malicious code, and generally decrease the likelihood of reproducible or reliable installs.

Ensure that native code bindings are expected. Consumers may consider pure JS and functionally similar alternatives to avoid the challenges and risks associated with native code bindings.

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/@abandonware/bluetooth-hci-socket@0.5.3-10
  • @SocketSecurity ignore npm/@abandonware/noble@1.9.2-23

@jdabbech-ledger jdabbech-ledger merged commit ec0e331 into develop Feb 23, 2024
53 of 56 checks passed
@jdabbech-ledger jdabbech-ledger deleted the support/hotfix-merge-conflicts branch February 23, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli common Has changes in live-common desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM translations Translation files have been touched ui Has changes in the design system library
Projects
None yet
Development

Successfully merging this pull request may close these issues.