Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support: add generics lotties animations #645

Merged
merged 4 commits into from
Jul 28, 2022

Conversation

pierrelouis-c
Copy link
Contributor

@pierrelouis-c pierrelouis-c commented Jul 12, 2022

πŸ“ Description

Add generic lottie animation

❓ Context

  • Impacted projects: ledger-live-desktop
  • Linked resource(s): FAT-71

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes
    There is no test coverage because we are just adding lotties

πŸ“Έ Demo

lottie.mp4

πŸš€ Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Jul 12, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
live-common-tools βœ… Ready (Inspect) Visit Preview Jul 28, 2022 at 1:25PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Jul 28, 2022 at 1:25PM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Jul 28, 2022 at 1:25PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Jul 28, 2022 at 1:25PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Jul 12, 2022

πŸ¦‹ Changeset detected

Latest commit: 5de5eb2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
ledger-live-desktop Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the desktop Has changes in LLD label Jul 12, 2022
@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #645 (fccef30) into develop (342dce8) will decrease coverage by 0.19%.
The diff coverage is n/a.

❗ Current head fccef30 differs from pull request most recent head 5de5eb2. Consider uploading reports for the commit 5de5eb2 to get more accurate results

@@             Coverage Diff             @@
##           develop     #645      +/-   ##
===========================================
- Coverage    47.69%   47.49%   -0.20%     
===========================================
  Files          613      623      +10     
  Lines        27277    27751     +474     
  Branches      6827     7160     +333     
===========================================
+ Hits         13009    13181     +172     
+ Misses       14208    13448     -760     
- Partials        60     1122    +1062     
Flag Coverage Ξ”
test 47.49% <ΓΈ> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
libs/ledger-live-common/src/platform/converters.ts 35.71% <0.00%> (-25.83%) ⬇️
...-common/src/families/stellar/js-synchronization.ts 26.66% <0.00%> (-8.63%) ⬇️
...ve-common/src/families/stellar/js-signOperation.ts 22.91% <0.00%> (-4.87%) ⬇️
...on/src/families/stellar/deviceTransactionConfig.ts 7.69% <0.00%> (-3.42%) ⬇️
...on/src/families/stellar/js-getTransactionStatus.ts 9.09% <0.00%> (-3.41%) ⬇️
libs/ledger-live-common/src/account/helpers.ts 50.83% <0.00%> (-2.87%) ⬇️
libs/ledger-live-common/src/range.ts 94.87% <0.00%> (-2.57%) ⬇️
...s/ledger-live-common/src/families/stellar/logic.ts 13.25% <0.00%> (-2.32%) ⬇️
...er-live-common/src/families/stellar/transaction.ts 23.07% <0.00%> (-1.93%) ⬇️
...-common/src/families/bitcoin/js-synchronisation.ts 20.16% <0.00%> (-1.62%) ⬇️
... and 263 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 342dce8...5de5eb2. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jul 12, 2022

@pierrelouis-c

Screenshots: ❌

It seems this PR contains screenshots that are different from the base branch.
If you are sure all those changes are correct, you can comment on this PR with /generate-screenshots to update those screenshots.

Make sure all the changes are correct before running the command, as it will commit and push the new result to the PR.

windows

Actual Diff Expected
market-btc-buy-page-actual market-btc-buy-page-diff market-btc-buy-page-expected
market-btc-buy-page-actual market-btc-buy-page-diff market-btc-buy-page-expected

@pierrelouis-c pierrelouis-c changed the title support: add anonymized lotties animations [WIP] support: add anonymized lotties animations Jul 15, 2022
@gre gre requested a review from valpinkman July 26, 2022 15:51
@gre
Copy link
Contributor

gre commented Jul 26, 2022

@pierrelouis-c could you ignore the prettier of the json files?

@pierrelouis-c pierrelouis-c changed the title [WIP] support: add anonymized lotties animations support: add anonymized lotties animations Jul 28, 2022
@pierrelouis-c pierrelouis-c changed the title support: add anonymized lotties animations support: add generics lotties animations Jul 28, 2022
Copy link
Contributor

@thomasrogerlux thomasrogerlux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@pierrelouis-c pierrelouis-c merged commit 8800276 into develop Jul 28, 2022
@pierrelouis-c pierrelouis-c deleted the support/add-anonymimzed-lotties branch July 28, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants