-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support: add generics lotties animations #645
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
π¦ Changeset detectedLatest commit: 5de5eb2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## develop #645 +/- ##
===========================================
- Coverage 47.69% 47.49% -0.20%
===========================================
Files 613 623 +10
Lines 27277 27751 +474
Branches 6827 7160 +333
===========================================
+ Hits 13009 13181 +172
+ Misses 14208 13448 -760
- Partials 60 1122 +1062
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@pierrelouis-c could you ignore the prettier of the json files? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
π Description
Add generic lottie animation
β Context
ledger-live-desktop
β Checklist
There is no test coverage because we are just adding lotties
πΈ Demo
lottie.mp4
π Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.