Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround to re-enable pnpm cache in the CI #655

Merged
merged 2 commits into from
Jul 13, 2022

Conversation

elbywan
Copy link
Contributor

@elbywan elbywan commented Jul 13, 2022

📝 Description

Setting loglevel=warn prevents pnpm store from outputting multiple lines instead of a single one.
Should fix the CI until pnpm publishes a fix.

❓ Context

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Jul 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Jul 13, 2022 at 8:32AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Jul 13, 2022 at 8:32AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Jul 13, 2022 at 8:32AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Jul 13, 2022 at 8:32AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Jul 13, 2022

⚠️ No Changeset found

Latest commit: 2cb679c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added automation CI/CD stuff tools Has changes in tools labels Jul 13, 2022
@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #655 (75d3a51) into develop (fb55dba) will decrease coverage by 2.43%.
The diff coverage is n/a.

❗ Current head 75d3a51 differs from pull request most recent head 2cb679c. Consider uploading reports for the commit 2cb679c to get more accurate results

@@             Coverage Diff             @@
##           develop     #655      +/-   ##
===========================================
- Coverage    47.69%   45.25%   -2.44%     
===========================================
  Files          613      566      -47     
  Lines        27277    24828    -2449     
  Branches      6827     6346     -481     
===========================================
- Hits         13009    11237    -1772     
+ Misses       14208    13531     -677     
  Partials        60       60              
Flag Coverage Δ
test 45.25% <ø> (-2.44%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libs/ledger-live-common/src/range.ts 94.87% <0.00%> (-2.57%) ⬇️
libs/ledgerjs/packages/hw-app-btc/src/varint.ts
libs/ledgerjs/packages/hw-app-cosmos/src/Cosmos.ts
...gerjs/packages/hw-app-btc/src/compressPublicKey.ts
...dgerjs/packages/hw-app-btc/src/splitTransaction.ts
.../ledgerjs/packages/hw-app-btc/src/newops/psbtv2.ts
...s/packages/hw-app-btc/src/newops/merkelizedPsbt.ts
...s/hw-app-btc/src/shouldUseTrustedInputForSegwit.ts
...dgerjs/packages/cryptoassets/data/polygon-erc20.js
...bs/ledgerjs/packages/hw-app-btc/src/signMessage.ts
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb55dba...2cb679c. Read the comment docs.

@github-actions
Copy link
Contributor

@elbywan

Screenshots: ✅

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@elbywan elbywan merged commit b9b65a5 into develop Jul 13, 2022
@elbywan elbywan deleted the support/pnpm-cache-workaround branch July 13, 2022 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation CI/CD stuff tools Has changes in tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants