Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cherrypick: #6664 #6693

Merged
merged 1 commit into from
Apr 16, 2024
Merged

cherrypick: #6664 #6693

merged 1 commit into from
Apr 16, 2024

Conversation

CremaFR
Copy link
Member

@CremaFR CremaFR commented Apr 16, 2024

  • bugfix: close completeExchange drawer when sell or card

  • chore: changeset

  • chore: fix ci

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

cherrypick for release

❓ Context

- JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@CremaFR
bugfix: close completeExchange drawer when sell or card (#6664)
395687f 
* bugfix: close completeExchange drawer when sell or card

* chore: changeset

* chore: fix ci
@CremaFR CremaFR requested a review from a team as a code owner April 16, 2024 16:08
@vercel Vercel
Copy link

vercel bot commented Apr 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Apr 16, 2024 4:08pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Apr 16, 2024 4:08pm
native-ui-storybook ⬜️ Ignored (Inspect) Apr 16, 2024 4:08pm
react-ui-storybook ⬜️ Ignored (Inspect) Apr 16, 2024 4:08pm
web-tools ⬜️ Ignored (Inspect) Apr 16, 2024 4:08pm

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Apr 16, 2024
@CremaFR CremaFR merged commit ba007c4 into release Apr 16, 2024
26 of 31 checks passed
@CremaFR CremaFR deleted the bugfix/release-close-drawer branch April 16, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpellizzari-ledger cpellizzari-ledger cpellizzari-ledger approved these changes

Assignees

@CremaFR CremaFR

Labels
desktop Has changes in LLD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CremaFR @cpellizzari-ledger