-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LIVE-2734 convert bash scripts to JS scripts #698
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## develop #698 +/- ##
========================================
Coverage 47.92% 47.92%
========================================
Files 620 620
Lines 27870 27870
Branches 7174 7174
========================================
Hits 13358 13358
Misses 14454 14454
Partials 58 58
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Screenshots: ✅
There are no changes in the screenshots for this PR. If this is expected, you are good to go. |
6e3ae53
to
fdf1991
Compare
There as been no activity on this PR for the last 14 days. Please consider closing this PR. |
fdf1991
to
0839315
Compare
0839315
to
d8e9058
Compare
d8e9058
to
fec2759
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥂
📝 Description
Replace bash script by javascript scripts (that's a lot of scripts innit ?). We try to keep the dev setup agnostic, thus making it easier now for windows developers to access our postinstall scripts and whatnot.
scripts:
These were the most important I think. I might have cleaned up some old and unused scripts as well.
❓ Context
all ?
✅ Checklist
📸 Demo
NO DEMO
🚀 Expectations to reach
Workflow stays unchanged, but tools are now more agnostic. It should be easier for windows dev now. Everything must still build and work as before.
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.