Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIVE-2734 convert bash scripts to JS scripts #698

Merged
merged 8 commits into from
Aug 16, 2022

Conversation

valpinkman
Copy link
Member

@valpinkman valpinkman commented Jul 20, 2022

📝 Description

Replace bash script by javascript scripts (that's a lot of scripts innit ?). We try to keep the dev setup agnostic, thus making it easier now for windows developers to access our postinstall scripts and whatnot.

scripts:

  • sync-families-dispatch: LLM, LLD, LLC
  • postinstall: LLC, LLM, LLD

These were the most important I think. I might have cleaned up some old and unused scripts as well.

❓ Context

  • Impacted projects: all ?
  • Linked resource(s): LIVE-2734

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

NO DEMO

🚀 Expectations to reach

Workflow stays unchanged, but tools are now more agnostic. It should be easier for windows dev now. Everything must still build and work as before.

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@changeset-bot
Copy link

changeset-bot bot commented Jul 20, 2022

⚠️ No Changeset found

Latest commit: 0805187

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jul 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Aug 16, 2022 at 3:35PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Aug 16, 2022 at 3:35PM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Aug 16, 2022 at 3:35PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Aug 16, 2022 at 3:35PM (UTC)

@valpinkman valpinkman marked this pull request as draft July 20, 2022 12:50
@github-actions github-actions bot added cli common Has changes in live-common desktop Has changes in LLD mobile Has changes in LLM labels Jul 20, 2022
@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #698 (0805187) into develop (c321c29) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #698   +/-   ##
========================================
  Coverage    47.92%   47.92%           
========================================
  Files          620      620           
  Lines        27870    27870           
  Branches      7174     7174           
========================================
  Hits         13358    13358           
  Misses       14454    14454           
  Partials        58       58           
Flag Coverage Δ
test 47.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libs/ledger-live-common/src/generated/account.ts 100.00% <ø> (ø)
libs/ledger-live-common/src/generated/bridge/js.ts 100.00% <ø> (ø)
...bs/ledger-live-common/src/generated/bridge/mock.ts 100.00% <ø> (ø)
...ve-common/src/generated/deviceTransactionConfig.ts 100.00% <ø> (ø)
libs/ledger-live-common/src/generated/exchange.ts 100.00% <ø> (ø)
.../ledger-live-common/src/generated/hw-getAddress.ts 100.00% <ø> (ø)
...ledger-live-common/src/generated/hw-signMessage.ts 100.00% <ø> (ø)
libs/ledger-live-common/src/generated/mock.ts 100.00% <ø> (ø)
...edger-live-common/src/generated/platformAdapter.ts 100.00% <ø> (ø)
...bs/ledger-live-common/src/generated/transaction.ts 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

github-actions bot commented Jul 20, 2022

@valpinkman

Screenshots: ✅

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@github-actions
Copy link

There as been no activity on this PR for the last 14 days. Please consider closing this PR.

@github-actions github-actions bot added the ui Has changes in the design system library label Aug 16, 2022
Copy link
Contributor

@elbywan elbywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥂

@valpinkman valpinkman merged commit 0cff80c into develop Aug 16, 2022
@valpinkman valpinkman deleted the support/clean-bash-scripts branch August 16, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation CI/CD stuff cli common Has changes in live-common desktop Has changes in LLD mobile Has changes in LLM Stale ui Has changes in the design system library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants