Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIVE-3068 Update Polkadot app minimum version to 13.9250.0 #709

Merged
2 commits merged into from
Jul 27, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jul 21, 2022

📝 Description

Next update of Polkadot network requires a new version of the Nano app, need to enforce this minimum version in Live.

New version is 13.9250.0

❓ Context

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@ghost ghost added the HODL Do not merge label Jul 21, 2022
@ghost ghost self-requested a review July 21, 2022 15:46
@ghost ghost self-assigned this Jul 21, 2022
@changeset-bot
Copy link

changeset-bot bot commented Jul 21, 2022

🦋 Changeset detected

Latest commit: 92acf58

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@ledgerhq/live-common Patch
@ledgerhq/live-cli Patch
ledger-live-desktop Patch
live-mobile Patch
live-common-tools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Jul 21, 2022 at 3:48PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Jul 21, 2022 at 3:48PM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Jul 21, 2022 at 3:48PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Jul 21, 2022 at 3:48PM (UTC)

@github-actions github-actions bot added the common Has changes in live-common label Jul 21, 2022
@ghost
Copy link
Author

ghost commented Jul 21, 2022

HODL until the 13.9250.0 version is on provider 1.

@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #709 (92acf58) into develop (5719313) will decrease coverage by 0.35%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #709      +/-   ##
===========================================
- Coverage    47.71%   47.36%   -0.36%     
===========================================
  Files          614      603      -11     
  Lines        27332    27079     -253     
  Branches      7004     6950      -54     
===========================================
- Hits         13041    12825     -216     
+ Misses       13198    13186      -12     
+ Partials      1093     1068      -25     
Flag Coverage Δ
test 47.36% <ø> (-0.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libs/ledger-live-common/src/apps/support.ts 31.81% <ø> (ø)
libs/ledgerjs/packages/hw-app-str/src/Str.ts 68.75% <0.00%> (ø)
libs/ledgerjs/packages/hw-app-cosmos/src/Cosmos.ts 20.73% <0.00%> (ø)
libs/ledgerjs/packages/hw-app-helium/src/Helium.ts 89.28% <0.00%> (ø)
.../ledgerjs/packages/hw-app-algorand/src/Algorand.ts 29.03% <0.00%> (ø)
.../ledgerjs/packages/hw-app-polkadot/src/Polkadot.ts 20.77% <0.00%> (ø)
...dgerjs/packages/hw-app-helium/src/serialization.ts 92.64% <0.00%> (ø)
...js/packages/hw-app-eth/src/services/ledger/nfts.ts 12.50% <0.00%> (ø)
libs/ledgerjs/packages/cryptoassets/data/trc10.js
libs/ledgerjs/packages/cryptoassets/src/tokens.ts
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5719313...92acf58. Read the comment docs.

@github-actions
Copy link
Contributor

@haammar-ledger

Screenshots: ✅

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@ghost ghost merged commit f10d011 into develop Jul 27, 2022
@ghost ghost deleted the support/LIVE-3068-polkadot-min-app-version branch July 27, 2022 07:37
@desirendr desirendr added this to the Ledger Live Mobile 3.5.x milestone Jul 29, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common HODL Do not merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants