Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LIVE-13096][LIVE-13098][LLM][Flex] Wrong redirection and text overlaps during Send #7223

Merged
merged 2 commits into from
Jul 1, 2024
Merged

[LIVE-13096][LIVE-13098][LLM][Flex] Wrong redirection and text overlaps during Send #7223

merged 2 commits into from
Jul 1, 2024

Conversation

jiyuzhuang
Copy link
Contributor

@jiyuzhuang jiyuzhuang commented Jun 27, 2024 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • Fix Flex wrong onboarding workflow bug;
    • Fix title overlaps during Send on Flex.

📝 Description

  • Fix Flex wrong onboarding workflow bug;
  • Fix title overlaps during Send on Flex.

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@jiyuzhuang jiyuzhuang added the live-devices Device team label label Jun 27, 2024
@jiyuzhuang jiyuzhuang self-assigned this Jun 27, 2024
@vercel Vercel
Copy link

vercel bot commented Jun 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Jun 28, 2024 3:15pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jun 28, 2024 3:15pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 28, 2024 3:15pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 28, 2024 3:15pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Jun 28, 2024 3:15pm

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Jun 27, 2024
@jiyuzhuang jiyuzhuang marked this pull request as ready for review June 28, 2024 13:51
@jiyuzhuang jiyuzhuang requested review from a team as code owners June 28, 2024 13:51
@jiyuzhuang jiyuzhuang changed the title [LIVE-13096][LLM][Flex] Wrong redirection when the user tries to connect an unseeded device to My Ledger [LIVE-13096][LIVE-13098][LLM][Flex] Wrong redirection and text overlaps during Send Jun 28, 2024
jdabbech-ledger
jdabbech-ledger reviewed Jul 1, 2024
View reviewed changes
.changeset/weak-kings-flow.md
"live-mobile": patch
---

Fix redirecting to wrong workflow bug.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One changeset file should be enough

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains fixes for 2 tickets, so I think it's better to specify.

@jiyuzhuang jiyuzhuang merged commit 8ed82a5 into develop Jul 1, 2024
39 checks passed
@jiyuzhuang jiyuzhuang deleted the bugfix/live-13096 branch July 1, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gre gre gre approved these changes

@jdabbech-ledger jdabbech-ledger jdabbech-ledger approved these changes

Assignees

@jiyuzhuang jiyuzhuang

Labels
live-devices Device team label mobile Has changes in LLM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jiyuzhuang @gre @jdabbech-ledger