Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIVE-3095] - Bugfix: missing floor price import (develop) #737

Merged
2 commits merged into from
Jul 25, 2022

Conversation

lambertkevin
Copy link
Contributor

📝 Description

Add import that was removed during the ESBuild + Vite transition, causing a crash.

❓ Context

  • Impacted projects: ledger-live-mobile
  • Linked resource(s): https://ledgerhq.atlassian.net/browse/LIVE-3095

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Jul 25, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Jul 25, 2022 at 1:48PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Jul 25, 2022 at 1:48PM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Jul 25, 2022 at 1:48PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Jul 25, 2022 at 1:48PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Jul 25, 2022

🦋 Changeset detected

Latest commit: e3986b6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link

github-actions bot commented Jul 25, 2022

@haammar-ledger

Screenshots: ✅

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #737 (e3986b6) into develop (c9a1e3a) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #737      +/-   ##
===========================================
- Coverage    47.71%   47.70%   -0.01%     
===========================================
  Files          614      612       -2     
  Lines        27333    27201     -132     
  Branches      7004     6972      -32     
===========================================
- Hits         13042    12977      -65     
+ Misses       13200    13139      -61     
+ Partials      1091     1085       -6     
Flag Coverage Δ
test 47.70% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libs/ledgerjs/packages/hw-app-str/src/Str.ts 68.75% <0.00%> (ø)
libs/ledgerjs/packages/hw-app-helium/src/Helium.ts 89.28% <0.00%> (ø)
...dgerjs/packages/hw-app-helium/src/serialization.ts 92.64% <0.00%> (ø)
libs/ledgerjs/packages/hw-app-xrp/src/Xrp.ts
.../ledgerjs/packages/hw-app-polkadot/src/Polkadot.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9a1e3a...e3986b6. Read the comment docs.

@ghost ghost merged commit 8ee5ab9 into develop Jul 25, 2022
@ghost ghost deleted the bugfix/missing-floor-price-import-develop branch July 25, 2022 16:54
@desirendr desirendr added this to the Ledger Live Mobile 3.5.x milestone Jul 29, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants