Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/live 3027 #740

Merged
merged 2 commits into from
Jul 28, 2022
Merged

Bugfix/live 3027 #740

merged 2 commits into from
Jul 28, 2022

Conversation

juan-cortes
Copy link
Contributor

📝 Description

We are incorrectly showing the wrong value for the used app data space in the manager for LLM, it's showing the total maximum available data instead of the used one. This address that.

❓ Context

  • Impacted projects: `` ledger-live-mobile
  • Linked resource(s): ``

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

image

🚀 Expectations to reach

Used should reflect the total app size data, not the total size as it did before.

@vercel
Copy link

vercel bot commented Jul 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Jul 26, 2022 at 0:15AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Jul 26, 2022 at 0:15AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Jul 26, 2022 at 0:15AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Jul 26, 2022 at 0:15AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Jul 26, 2022

🦋 Changeset detected

Latest commit: 41f5e8c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the mobile Has changes in LLM label Jul 26, 2022
@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #740 (f3b5de5) into develop (1424539) will not change coverage.
The diff coverage is n/a.

❗ Current head f3b5de5 differs from pull request most recent head 41f5e8c. Consider uploading reports for the commit 41f5e8c to get more accurate results

@@            Coverage Diff             @@
##           develop     #740     +/-   ##
==========================================
  Coverage    47.71%   47.71%             
==========================================
  Files          614      614             
  Lines        27333    27333             
  Branches      7004     7001      -3     
==========================================
  Hits         13042    13042             
- Misses       13198    14231   +1033     
+ Partials      1093       60   -1033     
Flag Coverage Δ
test 47.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libs/ledger-live-common/src/env.ts 65.21% <0.00%> (ø)
libs/ledger-live-common/src/convert.ts 12.50% <0.00%> (ø)
libs/ledger-live-common/src/network.ts 70.93% <0.00%> (ø)
libs/ledger-live-common/src/promise.ts 65.95% <0.00%> (ø)
libs/ledger-live-common/src/api/Tron.ts 21.15% <0.00%> (ø)
libs/ledger-live-common/src/hw/index.ts 22.22% <0.00%> (ø)
libs/ledger-live-common/src/nft/hook.ts 33.33% <0.00%> (ø)
libs/ledger-live-common/src/api/Ripple.ts 29.16% <0.00%> (ø)
libs/ledger-live-common/src/api/socket.ts 8.19% <0.00%> (ø)
libs/ledger-live-common/src/apps/logic.ts 89.67% <0.00%> (ø)
... and 236 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1424539...41f5e8c. Read the comment docs.

@github-actions
Copy link
Contributor

@juan-cortes

Screenshots: ✅

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@alexandremgo alexandremgo changed the base branch from develop to release July 28, 2022 14:15
@alexandremgo alexandremgo merged commit 709020d into release Jul 28, 2022
@alexandremgo alexandremgo deleted the bugfix/LIVE-3027 branch July 28, 2022 14:31
@desirendr desirendr added this to the Ledger Live Mobile 3.5.x milestone Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants