Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix/ LIVE-3168 - LLM - SendFlow fix navigation issue #796

Merged
merged 6 commits into from
Aug 3, 2022

Conversation

LFBarreto
Copy link
Contributor

@LFBarreto LFBarreto commented Aug 1, 2022

πŸ“ Description

LLM - send flow navigation issue fix

❓ Context

  • Impacted projects: ledger-live-mobile
  • Linked resource(s): LIVE-3168

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

πŸš€ Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@changeset-bot
Copy link

changeset-bot bot commented Aug 1, 2022

πŸ¦‹ Changeset detected

Latest commit: 206cac4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Aug 1, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
live-common-tools βœ… Ready (Inspect) Visit Preview Sep 3, 2022 at 9:05AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Sep 3, 2022 at 9:05AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Sep 3, 2022 at 9:05AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Sep 3, 2022 at 9:05AM (UTC)

@github-actions github-actions bot added the mobile Has changes in LLM label Aug 1, 2022
@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #796 (206cac4) into release (1b1e4ac) will increase coverage by 2.04%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           release     #796      +/-   ##
===========================================
+ Coverage    45.32%   47.37%   +2.04%     
===========================================
  Files          587      620      +33     
  Lines        25582    27479    +1897     
  Branches      6716     7118     +402     
===========================================
+ Hits         11595    13017    +1422     
- Misses       12899    13367     +468     
- Partials      1088     1095       +7     
Flag Coverage Ξ”
test 47.37% <ΓΈ> (+2.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
libs/ledgerjs/packages/cryptoassets/src/tokens.ts 75.00% <0.00%> (ΓΈ)
libs/ledgerjs/packages/hw-app-helium/src/Helium.ts 89.28% <0.00%> (ΓΈ)
...dgerjs/packages/hw-app-helium/src/serialization.ts 92.64% <0.00%> (ΓΈ)
...js/packages/hw-app-eth/src/services/ledger/nfts.ts 12.50% <0.00%> (ΓΈ)
libs/ledgerjs/packages/errors/src/helpers.ts
libs/ledgerjs/packages/errors/src/index.ts
libs/ledgerjs/packages/devices/src/index.ts
...dgerjs/packages/hw-app-btc/tests/speculosclient.ts 80.00% <0.00%> (ΓΈ)
libs/ledgerjs/packages/hw-app-btc/src/BtcOld.ts 95.00% <0.00%> (ΓΈ)
.../ledgerjs/packages/hw-app-btc/src/hashPublicKey.ts 100.00% <0.00%> (ΓΈ)
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 1b1e4ac...206cac4. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Aug 3, 2022

@LFBarreto

Screenshots: ❌

It seems this PR contains screenshots that are different from the base branch.
If you are sure all those changes are correct, you can comment on this PR with /generate-screenshots to update those screenshots.

Make sure all the changes are correct before running the command, as it will commit and push the new result to the PR.

linux

Actual Diff Expected
undefined undefined trace
undefined undefined trace

@LFBarreto LFBarreto merged commit 6cb11e2 into release Aug 3, 2022
@LFBarreto LFBarreto deleted the bugfix/LIVE-3168-llm-send-flow-navigation-issue branch August 3, 2022 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation CI/CD stuff mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants