Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIVE-2828 - LLM - Receive flow fix issue on token account creation name #797

Conversation

LFBarreto
Copy link
Contributor

@LFBarreto LFBarreto commented Aug 1, 2022

πŸ“ Description

LLM Receive flow fixes missing parent account name during token account scanning

❓ Context

  • Impacted projects: ledger-live-mobile
  • Linked resource(s): LIVE-2828

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

πŸš€ Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Aug 1, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
live-common-tools βœ… Ready (Inspect) Visit Preview Sep 3, 2022 at 10:01AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Sep 3, 2022 at 10:01AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Sep 3, 2022 at 10:01AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Sep 3, 2022 at 10:01AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Aug 1, 2022

πŸ¦‹ Changeset detected

Latest commit: b2eb193

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the mobile Has changes in LLM label Aug 1, 2022
@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #797 (b2eb193) into release (8040d39) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           release     #797   +/-   ##
========================================
  Coverage    47.49%   47.49%           
========================================
  Files          623      623           
  Lines        27751    27751           
  Branches      7160     7160           
========================================
  Hits         13181    13181           
  Misses       13448    13448           
  Partials      1122     1122           
Flag Coverage Ξ”
test 47.49% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 8040d39...b2eb193. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Aug 1, 2022

@LFBarreto

Screenshots: ❌

It seems this PR contains screenshots that are different from the base branch.
If you are sure all those changes are correct, you can comment on this PR with /generate-screenshots to update those screenshots.

Make sure all the changes are correct before running the command, as it will commit and push the new result to the PR.

linux

Actual Diff Expected
undefined undefined trace
undefined undefined trace

@LFBarreto LFBarreto force-pushed the bugfix/LIVE-2828-llm-receive-toke-accounts-parent-name-issue branch from e11a547 to b2eb193 Compare August 3, 2022 09:56
@LFBarreto LFBarreto merged commit d1011f2 into release Aug 3, 2022
@LFBarreto LFBarreto deleted the bugfix/LIVE-2828-llm-receive-toke-accounts-parent-name-issue branch August 3, 2022 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants