fix(llm): triggering proper error on CLS mobile disconnection #7979
+30
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
live-github-bot
bot
added
mobile
fAnselmi-Ledger
force-pushed
the
LIVE-13084-LLM-Flex-Stax-Error-loading-too-long-when-user-power-off-his-Flex-during-CLS-uploading
branch
from
eb8c1e7 to
63bb486
Compare
valpinkman
approved these changes
Oct 7, 2024
jiyuzhuang
reviewed
Oct 7, 2024
| timeout(5000), | ||
| catchError(err => { | ||
| if (err.name === "TimeoutError") { | ||
| return throwError(() => new DisconnectedDevice()); |
There was a problem hiding this comment.
The throwError in operator is normally not necessary, look at here.
There was a problem hiding this comment.
Hey @jiyuzhuang! I wrote that to show disconnection error after 5 seconds of timeout
| @@ -213,6 +212,14 @@ export default function loadImage({ deviceId, request }: Input): Observable<Load | |||
| sub.unsubscribe(); | |||
| }; | |||
| }), | |||
| ).pipe( | |||
There was a problem hiding this comment.
[ask] isn't it the purpose of the optional argument openTimeoutMs of withDevice ?
fAnselmi-Ledger
force-pushed
the
LIVE-13084-LLM-Flex-Stax-Error-loading-too-long-when-user-power-off-his-Flex-during-CLS-uploading
branch
from
63bb486 to
d2603b1
Compare
fAnselmi-Ledger
force-pushed
the
LIVE-13084-LLM-Flex-Stax-Error-loading-too-long-when-user-power-off-his-Flex-during-CLS-uploading
branch
from
d2603b1 to
b89d1e1
Compare
LucasWerey
approved these changes
Oct 23, 2024
fAnselmi-Ledger
deleted the
LIVE-13084-LLM-Flex-Stax-Error-loading-too-long-when-user-power-off-his-Flex-during-CLS-uploading
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
❓ Context
🧐 Checklist for the PR Reviewers