Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(live-14205): add ptxSwapCoreExperiment flag 2 #8053

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat(live-14205): add ptxSwapCoreExperiment flag 2 #8053

wants to merge 1 commit into from

Conversation

liviuciulinaru
Copy link
Contributor

@liviuciulinaru liviuciulinaru commented Oct 9, 2024 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

add ptxSwapCoreExperiment flag based on this logic https://ledgerhq.atlassian.net/wiki/spaces/PTX/pages/5002821634/SWAP+AB+Test+Plan+Document+Improving+User+Flow+by+Improving+quotes+display+-+Demo+3?focusedCommentId=5089132693

initial pr #8039

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@liviuciulinaru liviuciulinaru requested a review from a team as a code owner October 9, 2024 09:52
@vercel Vercel
Copy link

vercel bot commented Oct 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 3:13pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Oct 9, 2024 3:13pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Oct 9, 2024 3:13pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 9, 2024 3:13pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 9, 2024 3:13pm

@liviuciulinaru liviuciulinaru marked this pull request as draft October 9, 2024 09:52
@live-github-bot live-github-bot bot added the ledgerjs Has changes in the ledgerjs open source libs label Oct 9, 2024
@live-github-bot live-github-bot bot added the common Has changes in live-common label Oct 9, 2024
@liviuciulinaru liviuciulinaru marked this pull request as ready for review October 9, 2024 11:08
@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Oct 9, 2024
@liviuciulinaru liviuciulinaru requested a review from a team as a code owner October 9, 2024 11:50
@liviuciulinaru
feat: add ptxSwapCoreExperiment
4822945 
feat: 2

chore: 3

chore: another build

chore: another build

chore: another build

chore: another build

chore changeset
@liviuciulinaru liviuciulinaru changed the title feat: add ptxSwapCoreExperiment 2 feat(live-14205): add ptxSwapCoreExperiment flag 2 Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themooneer themooneer themooneer approved these changes

@kallen-ledger kallen-ledger kallen-ledger approved these changes

Assignees

@liviuciulinaru liviuciulinaru

Labels
common Has changes in live-common desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liviuciulinaru @themooneer @kallen-ledger