Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support/ LIVE-3132 - LLM - Live apps permission microphone required #811

Merged

Conversation

LFBarreto
Copy link
Contributor

@LFBarreto LFBarreto commented Aug 2, 2022

📝 Description

Add microphone permission for android for live apps

❓ Context

  • Impacted projects: ledger-live-mobile
  • Linked resource(s): LIVE-3132

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Aug 2, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Sep 3, 2022 at 9:58AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Sep 3, 2022 at 9:58AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Sep 3, 2022 at 9:58AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Sep 3, 2022 at 9:58AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Aug 2, 2022

🦋 Changeset detected

Latest commit: 0872e66

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #811 (e8466d1) into release (206cac4) will increase coverage by 0.12%.
The diff coverage is n/a.

❗ Current head e8466d1 differs from pull request most recent head 0872e66. Consider uploading reports for the commit 0872e66 to get more accurate results

@@             Coverage Diff             @@
##           release     #811      +/-   ##
===========================================
+ Coverage    47.37%   47.49%   +0.12%     
===========================================
  Files          620      623       +3     
  Lines        27479    27751     +272     
  Branches      7118     7157      +39     
===========================================
+ Hits         13017    13181     +164     
- Misses       13367    14510    +1143     
+ Partials      1095       60    -1035     
Flag Coverage Δ
test 47.49% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libs/ledger-live-common/src/env.ts 80.43% <0.00%> (ø)
libs/ledger-live-common/src/convert.ts 12.50% <0.00%> (ø)
libs/ledger-live-common/src/network.ts 70.93% <0.00%> (ø)
libs/ledger-live-common/src/promise.ts 65.95% <0.00%> (ø)
libs/ledger-live-common/src/api/Tron.ts 21.15% <0.00%> (ø)
libs/ledger-live-common/src/hw/index.ts 22.22% <0.00%> (ø)
libs/ledger-live-common/src/nft/hook.ts 33.33% <0.00%> (ø)
libs/ledger-live-common/src/api/Ripple.ts 29.16% <0.00%> (ø)
libs/ledger-live-common/src/api/socket.ts 8.19% <0.00%> (ø)
libs/ledger-live-common/src/apps/logic.ts 89.67% <0.00%> (ø)
... and 240 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8040d39...0872e66. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Aug 2, 2022

@LFBarreto

Screenshots: ✅

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@LFBarreto LFBarreto merged commit eda82de into release Aug 3, 2022
@LFBarreto LFBarreto deleted the support/LIVE-3132-LLM-add-microphone-autorisation branch August 3, 2022 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants