feat/LIVE-3148 Added development/QA tool for feature flags #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 77406d0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
common
apps/ledger-live-desktop/src/renderer/components/FirebaseFeatureFlags.tsx
Outdated
Show resolved
Hide resolved
apps/ledger-live-mobile/src/screens/Settings/Debug/OpenDebugFeatureFlags.js
Show resolved
Hide resolved
thomasrogerlux
approved these changes
Aug 2, 2022
Screenshots: ✅
There are no changes in the screenshots for this PR. If this is expected, you are good to go. |
Codecov Report
@@ Coverage Diff @@
## develop #814 +/- ##
========================================
Coverage 47.93% 47.93%
========================================
Files 620 620
Lines 27870 27870
Branches 7174 7174
========================================
Hits 13359 13359
Misses 14453 14453
Partials 58 58
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
apps/ledger-live-desktop/src/renderer/components/FirebaseFeatureFlags.tsx
Outdated
Show resolved
Hide resolved
juan-cortes
force-pushed
the
feat/LIVE-3148
branch
from
3644ac2 to
4ef6152
Compare
Justkant
requested changes
Aug 5, 2022
apps/ledger-live-desktop/src/renderer/components/FirebaseFeatureFlags.tsx
Outdated
Show resolved
Hide resolved
apps/ledger-live-mobile/src/components/FirebaseFeatureFlags.tsx
Outdated
Show resolved
Hide resolved
juan-cortes
force-pushed
the
feat/LIVE-3148
branch
from
4ef6152 to
2590a54
Compare
|
@Justkant Take a look again when you have a minute :beau: |
Justkant
approved these changes
Aug 11, 2022
juan-cortes
force-pushed
the
feat/LIVE-3148
branch
from
2590a54 to
d388bb2
Compare
chabroA
previously requested changes
Aug 16, 2022
apps/ledger-live-desktop/src/renderer/components/FirebaseFeatureFlags.tsx
Outdated
Show resolved
Hide resolved
juan-cortes
force-pushed
the
feat/LIVE-3148
branch
from
1dd0031 to
c34b469
Compare
juan-cortes
force-pushed
the
feat/LIVE-3148
branch
from
c34b469 to
77406d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Due to the nature of the integration with firebase it's not easy to test features that work differently depending on the value of a feature flag from firebase. This PR introduces a tool for LLM and a tool for LLD that allows us to locally override the value of the feature flag for that particular app run. The overrides are not persisted between application launches.
It matches partially the https://ledgerhq.atlassian.net/browse/LIVE-3148 task but I leave it to hub and @thomasrogerlux to take over any remaining topics. This should merely allow us to test and dev with changing values for the flags.
❓ Context
ledger-live-desktop,ledger-live-mobile,ledger-live-commonhttps://ledgerhq.atlassian.net/browse/LIVE-3148✅ Checklist
📸 Demo
🚀 Expectations to reach
There should be no impact on the functionality of the app. When we change the value of a feature it should act as if the value returned from firebase was the one overriden.