fix(iOS): Solana error after broadcast on WebSockets [LIVE-14585] #8169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are adding a missing user-agent header on the websocket for iOS with RN facebook/react-native#28450 facebook/react-native#30727 We need to use the interceptor as we don't control the code initiating the websocket Updating the options passed in by the interceptor works fine https://github.com/facebook/react-native/blob/3dfe22bd27429a43b4648c597b71f7965f31ca65/packages/react-native/Libraries/WebSocket/WebSocketInterceptor.js#L148-L163 Another solution could be to use pnpm to patch react native WebSocket linked below https://github.com/facebook/react-native/blob/3dfe22bd27429a43b4648c597b71f7965f31ca65/packages/react-native/Libraries/WebSocket/WebSocket.js But the interceptor seems lean enough and a simple hack vs patching a lib seems preferable
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Skipped Deployments
|
KVNLS
approved these changes
Oct 22, 2024
cgrellard-ledger
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Our proxy for Solana is blocking the connection when no user-agent is provided
We are adding the missing user-agent header on the websocket for iOS with RN
We need to use the interceptor as we don't control the code initiating the websocket
Updating the options passed in by the interceptor works fine
Another solution could be to use pnpm to patch react native WebSocket
But the interceptor seems lean enough and a simple hack vs patching a lib seems preferable
Related issues:
❓ Context
🧐 Checklist for the PR Reviewers