Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(llm): ✨ memo tag support inference from send flow #8191

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

thesan
Copy link
Contributor

@thesan thesan commented Oct 24, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Small improvement on the memo tag information on the receive flow. Nothing changes UI wise but instead of maintaining a constant with the list of memo tag supporting coins. It detects which coins implements a memo tag input on the send flow.

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@thesan thesan requested a review from a team as a code owner October 24, 2024 09:58
@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Oct 24, 2024
Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Oct 24, 2024 9:59am
ledger-live-github-bot ⬜️ Ignored (Inspect) Oct 24, 2024 9:59am
native-ui-storybook ⬜️ Ignored (Inspect) Oct 24, 2024 9:59am
react-ui-storybook ⬜️ Ignored (Inspect) Oct 24, 2024 9:59am
web-tools ⬜️ Ignored (Inspect) Oct 24, 2024 9:59am

@thesan thesan merged commit de89b29 into develop Oct 24, 2024
43 checks passed
@thesan thesan deleted the feat/llm-memo-tag-receive-flow-inference branch October 24, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants