Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📈 LLM - Flush analytics events when putting the app in background #8232

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

cgrellard-ledger
Copy link
Contributor

@cgrellard-ledger cgrellard-ledger commented Oct 29, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:

📝 Description

We call the segment flush method when we detect that LLM goes in the background to send the events are to segment during the same session (without having to wait for the user to open the app again before sending them)

Android iOS
https://github.com/user-attachments/assets/d092480a-925a-42e5-8ae4-64ad7619a756 https://github.com/user-attachments/assets/587ed072-62fa-4db9-b80d-a9ee983cc614

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@cgrellard-ledger cgrellard-ledger requested a review from a team as a code owner October 29, 2024 10:28
Copy link

vercel bot commented Oct 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 10:31am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 10:31am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 10:31am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 10:31am
web-tools ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 10:31am

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Oct 29, 2024
@cgrellard-ledger cgrellard-ledger changed the title LLM - Flush analytics events when putting the app in background 📈 LLM - Flush analytics events when putting the app in background Oct 29, 2024
@cgrellard-ledger cgrellard-ledger merged commit 18973b7 into develop Oct 29, 2024
43 of 47 checks passed
@cgrellard-ledger cgrellard-ledger deleted the bugfix/llm-analytics-events-delayed branch October 29, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants