➖ LLM - Remove Adjust #8248
Merged
➖ LLM - Remove Adjust #8248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Skipped Deployments
|
ypolishchuk-ledger
previously approved these changes
Oct 30, 2024
mcayuelas-ledger
previously approved these changes
Oct 30, 2024
bharamboure-ledger
approved these changes
Oct 30, 2024
themooneer
reviewed
Oct 30, 2024
themooneer
reviewed
Oct 30, 2024
ofreyssinet-ledger
requested changes
Oct 30, 2024
There was a problem hiding this comment.
🙅 We can't do that for now as Adjust is used for universal links, which are used for QR codes displayed on Stax/Flex, to redirect users to Ledger Live.
More info here: #3115
themooneer
previously approved these changes
Oct 30, 2024
bharamboure-ledger
previously approved these changes
Oct 30, 2024
cgrellard-ledger
dismissed stale reviews from bharamboure-ledger, themooneer, mcayuelas-ledger, and ypolishchuk-ledger
via
ecd88c4
Wozacosta
previously approved these changes
Oct 30, 2024
Universal links are already broken in production since we stopped our contract with adjust on August 3rd |
ComradeAERGO
previously approved these changes
Oct 30, 2024
themooneer
previously approved these changes
Oct 30, 2024
…rts from the codebase
cgrellard-ledger
dismissed stale reviews from themooneer, ComradeAERGO, and Wozacosta
via
de0f343
cgrellard-ledger
force-pushed
the
feat/llm-remove-react-native-adjust-sdk
branch
from
ecd88c4 to
de0f343
Compare
…ovider to keep supporting those deeplinks when scanning a qr code on a stax or a flex
cgrellard-ledger
force-pushed
the
feat/llm-remove-react-native-adjust-sdk
branch
from
de0f343 to
de397a9
Compare
ofreyssinet-ledger
approved these changes
Oct 30, 2024
ComradeAERGO
approved these changes
Oct 30, 2024
KVNLS
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Remove the
react-native-adjustpackage from LLM and all Adjust related parts from the codebaseWe need to make sure that removing the
com.google.android.gms.permission.AD_IDpermission has no impact on other analytics packagesSame for the removal of
implementation 'com.google.android.gms:play-services-analytics:10.0.1'andimplementation 'com.android.installreferrer:installreferrer:1.0'❓ Context
🧐 Checklist for the PR Reviewers