Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade react-native-reanimated to 3.16.1 - develop #8322

Merged
merged 2 commits into from
Nov 12, 2024
Merged

chore: upgrade react-native-reanimated to 3.16.1 - develop #8322

merged 2 commits into from
Nov 12, 2024

Conversation

KVNLS
Copy link
Member

@KVNLS KVNLS commented Nov 6, 2024 •
edited by LucasWerey
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • reanimated

📝 Description

Upgrade reanimated on LLM. And replace deprecated enum.
This fix an issue that we have on pre release too

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@KVNLS KVNLS self-assigned this Nov 6, 2024
@vercel Vercel
Copy link

vercel bot commented Nov 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 10:36am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 10:36am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 10:36am
web-tools ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 10:36am

@live-github-bot live-github-bot bot added mobile Has changes in LLM ui Has changes in the design system library labels Nov 6, 2024
@LucasWerey LucasWerey marked this pull request as ready for review November 12, 2024 12:43
@LucasWerey LucasWerey requested review from a team as code owners November 12, 2024 12:43
themooneer
themooneer approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@themooneer themooneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LucasWerey LucasWerey changed the title chore: upgrade react-native-reanimated to 3.16.1 chore: upgrade react-native-reanimated to 3.16.1 - develop Nov 12, 2024
@LucasWerey LucasWerey merged commit a86b032 into develop Nov 12, 2024
46 of 56 checks passed
@LucasWerey LucasWerey deleted the fix/upgrade-reanimated branch November 12, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgrellard-ledger cgrellard-ledger cgrellard-ledger approved these changes

@themooneer themooneer themooneer approved these changes

@Justkant Justkant Justkant approved these changes

Assignees

@KVNLS KVNLS

Labels
mobile Has changes in LLM ui Has changes in the design system library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KVNLS @Justkant @themooneer @cgrellard-ledger @LucasWerey