Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(llm): ✨ remove commas from XRP summary tag #8352

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

thesan
Copy link
Contributor

@thesan thesan commented Nov 12, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Remove the local number formating of the the XRP tag.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@thesan thesan requested a review from a team as a code owner November 12, 2024 16:55
Copy link

vercel bot commented Nov 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Nov 12, 2024 4:55pm
native-ui-storybook ⬜️ Ignored (Inspect) Nov 12, 2024 4:55pm
react-ui-storybook ⬜️ Ignored (Inspect) Nov 12, 2024 4:55pm
web-tools ⬜️ Ignored (Inspect) Nov 12, 2024 4:55pm

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Nov 12, 2024
@thesan thesan merged commit f46c5b4 into develop Nov 14, 2024
42 of 44 checks passed
@thesan thesan deleted the fix/llm-xrp-tag-summary-format branch November 14, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants