fix: playwright, and wrong import and export #8391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
Wozacosta
previously approved these changes
Nov 18, 2024
Wozacosta
changed the title
Wozacosta
force-pushed
the
fix/import-setup-stacks
branch
from
0337d0a to
2747ffb
Compare
Justkant
reviewed
Nov 19, 2024
KVNLS
previously approved these changes
Nov 19, 2024
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| import { createBridges } from "@ledgerhq/coin-stacks"; | |||
| import stacksResolver, { signMessage } from "@ledgerhq/coin-stacks/signer/index"; | |||
| import makeCliTools from "@ledgerhq/coin-xrp/test/cli"; | |||
| import makeCliTools from "@ledgerhq/coin-stacks/test/cli"; | |||
There was a problem hiding this comment.
No the original was a mix up, this changes in this PR are intentional
There was a problem hiding this comment.
yes that was the point of this PR at first then @Wozacosta fixed playwright
ypolishchuk-ledger
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
wrong import and export !
Also, fixes a playwright test:
Before
When trying to click the 7 day time range, we ended up clicking on dogecoin !
https://github.com/LedgerHQ/ledger-live/actions/runs/11897758228/job/33187953305?pr=8159
To fix this, we now select within the time range dropdown before clicking on the element containing "7d"
❓ Context
🧐 Checklist for the PR Reviewers