Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lld): 🐦‍🔥 revamp the portfolio content cards #8397

Merged
merged 16 commits into from
Nov 27, 2024
Merged

feat(lld): 🐦‍🔥 revamp the portfolio content cards #8397

merged 16 commits into from
Nov 27, 2024

Conversation

thesan
Copy link
Contributor

@thesan thesan commented Nov 19, 2024 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Last PR for "LLD - Portfolio Content Card Revamp".

Use the Carousel and PortfolioContentCard components from "@ledgerhq/react-ui" to revamp the portfolio content cards.

Screen.Recording.2024-11-22.at.17.47.06.mov
Screen.Recording.2024-11-22.at.17.50.11.mov

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Nov 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-ui-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2024 8:20am
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2024 8:20am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2024 8:20am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2024 8:20am

@live-github-bot live-github-bot bot added desktop Has changes in LLD translations Translation files have been touched labels Nov 19, 2024
@thesan thesan force-pushed the feat/lld-portfolio-cards-ui branch from ae830d3 to 182c7d0 Compare November 20, 2024 09:45
@thesan thesan force-pushed the feat/lld-portfolio-cards-revamp branch from 4a1712a to 6c22dcd Compare November 20, 2024 09:46
@live-github-bot live-github-bot bot added the ui Has changes in the design system library label Nov 20, 2024
@thesan thesan force-pushed the feat/lld-portfolio-cards-ui branch from 182c7d0 to 024e6c5 Compare November 20, 2024 11:19
@thesan thesan force-pushed the feat/lld-portfolio-cards-revamp branch from 9d9ba9e to 34849e5 Compare November 20, 2024 11:20
@thesan thesan force-pushed the feat/lld-portfolio-cards-ui branch from ee85e23 to 3688396 Compare November 22, 2024 09:31
@thesan thesan force-pushed the feat/lld-portfolio-cards-revamp branch from a5003cf to fa2700a Compare November 22, 2024 09:34
Base automatically changed from feat/lld-portfolio-cards-ui to develop November 22, 2024 16:24
@thesan thesan force-pushed the feat/lld-portfolio-cards-revamp branch from 1b37ad6 to 2573e61 Compare November 22, 2024 16:51
@thesan thesan marked this pull request as ready for review November 22, 2024 16:54
@thesan thesan requested a review from a team as a code owner November 22, 2024 16:54
@thesan thesan force-pushed the feat/lld-portfolio-cards-revamp branch from 2573e61 to 6bd8f6d Compare November 25, 2024 08:50
@thesan thesan force-pushed the feat/lld-portfolio-cards-revamp branch from d48d99d to 5fc7206 Compare November 25, 2024 10:02
@thesan thesan force-pushed the feat/lld-portfolio-cards-revamp branch from e86595f to 0e02be3 Compare November 26, 2024 15:35
themooneer
themooneer reviewed Nov 26, 2024
View reviewed changes
libs/ui/packages/react/src/components/layout/Carousel/types.tsx Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for tsx here ts is sufficient

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I renamed the file but it wasn't the one I created in this PR

thesan added 16 commits November 27, 2024 09:08
@thesan
feat(lld): add cta and tag to the PortfolioContentCard type
56da56d
@thesan
feat(lld): replace the old portfolio content cards carousel
8932ddb
@thesan
feat(lld): add cta and tag to the mocked portfolio cards from the bra…
eb1f318 
…ze dev tool
@thesan
feat(lld): autoplay the carousel
1ecff45
@thesan
feat(lld): restore segment tracking
4e759a8
@thesan
feat(lld): log the ccard impressions with LogContentCardWrapper
4551b18
@thesan
chore(lld): rename LLD/feature/Growth to LLD/feature/DynamicContent
3f01e0b
@thesan
fix(lld): track "contentcards_slide" events with the actual buttons i…
667213f 
…nteraction
@thesan
feat(lld): report prev/next swipes from the UI Carousel
fce248f
@thesan
chore(lld): test the portfolio content cards carousel
208cf82
@thesan
chore: update change log
046dc2d
@thesan
fix(lld): make portfolio content cards fit the whole carousel width
e37f66f
@thesan
chore(lld): simplify the carousel watchDragX implementation
4d6082c
@thesan
fix(lld): do not render empty carousels
957c2a6
@thesan
chore(lld): address change requests
c178789
@thesan
chore(lld): rename react-ui/components/layout/Carousel/types.ts
42defb3
@thesan thesan force-pushed the feat/lld-portfolio-cards-revamp branch from 0e02be3 to 42defb3 Compare November 27, 2024 08:08
@thesan thesan merged commit 2a9e2de into develop Nov 27, 2024
43 of 44 checks passed
@thesan thesan deleted the feat/lld-portfolio-cards-revamp branch November 27, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcayuelas-ledger mcayuelas-ledger mcayuelas-ledger left review comments

@themooneer themooneer themooneer approved these changes

Assignees

@thesan thesan

Labels
desktop Has changes in LLD translations Translation files have been touched ui Has changes in the design system library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thesan @themooneer @mcayuelas-ledger